Skip to content

fix: update labeler#9637

Merged
snowystinger merged 3 commits intomainfrom
fix-labeler
Feb 11, 2026
Merged

fix: update labeler#9637
snowystinger merged 3 commits intomainfrom
fix-labeler

Conversation

@yihuiliao
Copy link
Member

The labeler was marking s2 changes as v3 because I forgot that s2 is also under the @react-spectrum directory. Hopefully this fixes that

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger
snowystinger previously approved these changes Feb 10, 2026
@rspbot
Copy link

rspbot commented Feb 10, 2026

@rspbot
Copy link

rspbot commented Feb 10, 2026

@snowystinger
Copy link
Member

had a thought, should we exclude tests, stories, docs from auto labelling too?

@yihuiliao
Copy link
Member Author

@snowystinger i think a lot of times docs, tests, stories, are in combination with actual changes. rarely do i feel like we have just test changes or story changes (docs are more likely to be standalone)

@snowystinger snowystinger added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 7009388 Feb 11, 2026
29 checks passed
@snowystinger snowystinger deleted the fix-labeler branch February 11, 2026 23:56
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session ready for review small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants