Skip to content

fix(RAC): use KeyboardProps in Keyboard component and context#9668

Open
artola wants to merge 1 commit intoadobe:mainfrom
artola:fix/keyboard-context-typing
Open

fix(RAC): use KeyboardProps in Keyboard component and context#9668
artola wants to merge 1 commit intoadobe:mainfrom
artola:fix/keyboard-context-typing

Conversation

@artola
Copy link
Contributor

@artola artola commented Feb 17, 2026

Closes #9666

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Use KeyboardProps as the prop type in the Keyboard component
  2. Verify TypeScript correctly identifies render prop and other props from DOMRenderProps<'kbd', undefined>
  3. Verify no TypeScript errors when using the Keyboard component with the render prop

🧢 Your Project:

React Aria Components

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typings for RAC Keyboard

2 participants