Merged
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
changed the title
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
reviewed
Mar 3, 2026
| default: 'default', | ||
| isLink: 'pointer' | ||
| }, | ||
| transition: 'default', |
Member
There was a problem hiding this comment.
prevents the border from transitioning. I didn't see anything else that should transition since the background is rendered as a separate layer
devongovett
reviewed
Mar 3, 2026
| position: 'absolute', | ||
| zIndex: -1, | ||
| top: 0, | ||
| top: { |
Member
There was a problem hiding this comment.
background overlaps the borders
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
changed the title
LFDanLu
reviewed
Mar 3, 2026
Comment on lines
+415
to
+423
| isFirstItem: { | ||
| isSelected: { | ||
| selectionStyle: { | ||
| checkbox: 'none', | ||
| highlight: 'default' | ||
| } | ||
| }, | ||
| isQuiet: 'default' | ||
| } |
Member
There was a problem hiding this comment.
should this just be default always? As noted by @reidbarber currently it looks like the below when keyboard focused.
Member
There was a problem hiding this comment.
ugh I was trying to avoid that because there is a small gap in the corner but I guess so. maybe I can change it when focused
|
Build successful! 🎉 |
LFDanLu
approved these changes
Mar 3, 2026
devongovett
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing fixes some of these RSP Component Milestones (view)
The first one appears intentional from design, but I'm double checking with them.
To test, turn scrollbars always on, then visit Example and Dynamic and set the various combinations of selectionStyle and isQuiet
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: