fix: Tree keyboard drag and drop should skip content nodes#9724
Merged
devongovett merged 1 commit intomainfrom Mar 3, 2026
Merged
fix: Tree keyboard drag and drop should skip content nodes#9724devongovett merged 1 commit intomainfrom
devongovett merged 1 commit intomainfrom
Conversation
|
Build successful! 🎉 |
LFDanLu
approved these changes
Mar 3, 2026
snowystinger
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some logic was previously added to skip content nodes in tree keyboard dnd but only when navigating down, not up. This adds it for the up direction as well. Tests did not previously catch this because the mock collection did not have content nodes either. When I added them it went into an infinite loop until I fixed the issue.
Test instructions
Open the RAC Tree drag and drop docs example, expand Documents and Photos, and attempt to keyboard drag Image 1 up above Project. Previously this went into a loop, and now it should work correctly.