Skip to content

fix(Tabs): default shouldSelectOnPressUp to true if item is a link#9827

Merged
reidbarber merged 4 commits intomainfrom
useTab-links-shouldSelectOnPressUp-true
Mar 23, 2026
Merged

fix(Tabs): default shouldSelectOnPressUp to true if item is a link#9827
reidbarber merged 4 commits intomainfrom
useTab-links-shouldSelectOnPressUp-true

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Mar 23, 2026

Defaults shouldSelectOnPressUp to true in useTab when the item is a link.

Fixes an issue where when beforeunload was used and the navigation was cancelled by the user, the browser would re-open the dialog when the link was hovered again.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check unit test.

🧢 Your Project:

@github-actions github-actions bot added the RAC label Mar 23, 2026
@rspbot
Copy link

rspbot commented Mar 23, 2026

@reidbarber reidbarber changed the title fix(useTab): default shouldSelectOnPressUp to true if item is a link fix(Tabs): default shouldSelectOnPressUp to true if item is a link Mar 23, 2026
snowystinger
snowystinger previously approved these changes Mar 23, 2026
@rspbot
Copy link

rspbot commented Mar 23, 2026

@reidbarber reidbarber added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 2f114b3 Mar 23, 2026
30 checks passed
@reidbarber reidbarber deleted the useTab-links-shouldSelectOnPressUp-true branch March 23, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants