fix(Tabs): default shouldSelectOnPressUp to true if item is a link#9827
Merged
reidbarber merged 4 commits intomainfrom Mar 23, 2026
Merged
fix(Tabs): default shouldSelectOnPressUp to true if item is a link#9827reidbarber merged 4 commits intomainfrom
reidbarber merged 4 commits intomainfrom
Conversation
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Mar 23, 2026
This reverts commit 981c1d8.
…lectOnPressUp-true
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 23, 2026
yihuiliao
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults
shouldSelectOnPressUptotrueinuseTabwhen the item is a link.Fixes an issue where when
beforeunloadwas used and the navigation was cancelled by the user, the browser would re-open the dialog when the link was hovered again.✅ Pull Request Checklist:
📝 Test Instructions:
Check unit test.
🧢 Your Project: