chore: Raise browserslist for modern bundlers, and fix old Jest#9831
Merged
devongovett merged 13 commits intomainfrom Mar 24, 2026
Merged
chore: Raise browserslist for modern bundlers, and fix old Jest#9831devongovett merged 13 commits intomainfrom
devongovett merged 13 commits intomainfrom
Conversation
devongovett
changed the title
This reverts commit 2c3240a.
devongovett
commented
Mar 24, 2026
| let express = false; | ||
| try { | ||
| provider = useProvider(); | ||
| express = (useProvider() as any).theme.global.express; |
Member
Author
There was a problem hiding this comment.
I don't want to deal with compiling a third version of every icon to support optional chaining in webpack 4.
devongovett
commented
Mar 24, 2026
| "next/@swc/helpers": "0.4.36" | ||
| } | ||
| }, | ||
| "browserslist": "defaults" |
Member
Author
There was a problem hiding this comment.
prevents nextjs picking up the browserslistrc at the root of the repo (the version used here is old and doesn't support baseline queries)
|
Build successful! 🎉 |
reidbarber
approved these changes
Mar 24, 2026
LFDanLu
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the Browserslist for our packages to baseline widely available so that less syntax gets transpiled, except for the legacy
.jsversions used by webpack 4 (which does not support parsing optional chaining). Now Parcel compiles three different versions of every file (CJS, ESM modern, and ESM legacy).Also fixes compatibility with Jest < 28, which doesn't support package exports (like webpack 4) but also only supports Common JS. So now for each subpath, we create a directory containing both CJS and ESM shims plus a package.json with "main" and "module" fields. Pretty ridiculous but otherwise we'd have to bump a major version.