Skip to content

fix: Button font and S2 dark mode#9840

Merged
devongovett merged 7 commits intomainfrom
fix-browserslist-bump
Mar 25, 2026
Merged

fix: Button font and S2 dark mode#9840
devongovett merged 7 commits intomainfrom
fix-browserslist-bump

Conversation

@devongovett
Copy link
Copy Markdown
Member

Fixes regressions caused by bumping the browserslist.

v3 Button font family was incorrect due to CSS nesting no longer being compiled. The composes property must be at the top, before any nested rules.

S2 dark mode was broken due to no longer compiling the light-dark() function. Some CSS was assuming we were using lightningcss's compiled version.

@github-actions github-actions bot added the S2 label Mar 25, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Mar 25, 2026

@devongovett devongovett changed the title fix: Button bump and S2 dark mode fix: Button font and S2 dark mode Mar 25, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Mar 25, 2026

reidbarber
reidbarber previously approved these changes Mar 25, 2026
snowystinger
snowystinger previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to the home page for react spectrum in the s2 docs, all the examples are now in light mode for me, but in production, they are in dark mode, like the rest of my app

I think @reidbarber theme switcher relied on the variables too?

@snowystinger snowystinger dismissed their stale review March 25, 2026 20:09

wrong button

@devongovett
Copy link
Copy Markdown
Member Author

@snowystinger good catch. The behavior here is a little weird, but I found the PR that added it: #6897. Updated to use a variable so that it continues to inherit the value set by page.css as well.

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 25, 2026

@snowystinger
Copy link
Copy Markdown
Member

Hmmm the S2 docs home page still isn't reacting to the theme switcher. It's now in the correct initial theme based on my system settings, but clicking the theme switcher won't change most of them.

@devongovett
Copy link
Copy Markdown
Member Author

good catch again

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 25, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 25, 2026

## API Changes

@internationalized/date

/@internationalized/date:DateValue

-DateValue {
-  D: undefined
-}

@react-spectrum/toast

/@react-spectrum/toast:CloseFunction

-CloseFunction {
-  C: undefined
-}

@react-stately/data

/@react-stately/data:AsyncListLoadFunction

-AsyncListLoadFunction {
-  A: undefined
-}

/@react-stately/data:AsyncListLoadOptions

-AsyncListLoadOptions <C, T> {
-  cursor?: C
-  filterText?: string
-  items: Array<T>
-  loadingState?: LoadingState
-  selectedKeys: Selection
-  signal: AbortSignal
-  sortDescriptor?: SortDescriptor
-}

/@react-stately/data:AsyncListStateUpdate

-AsyncListStateUpdate <C, T> {
-  cursor?: C
-  filterText?: string
-  items: Iterable<T>
-  selectedKeys?: Iterable<Key>
-  sortDescriptor?: SortDescriptor
-}

@devongovett devongovett enabled auto-merge March 25, 2026 22:03
@devongovett devongovett added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 471ef60 Mar 25, 2026
28 checks passed
@devongovett devongovett deleted the fix-browserslist-bump branch March 25, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants