Skip to content

chore: Revert 9875 and move disabledBehavior example in TableView docs#9914

Merged
snowystinger merged 3 commits intomainfrom
revert_9875
Apr 13, 2026
Merged

chore: Revert 9875 and move disabledBehavior example in TableView docs#9914
snowystinger merged 3 commits intomainfrom
revert_9875

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented Apr 11, 2026

Reverts #9875 since there are some design questions about chevron hover behavior and some unintended behavior where non-actionable disabled rows have hover styles when selectionMode="none". Ideally useTableRow would check for whether or not to add "row expand" action onto a row but we need to revisit why onAction was deprecated from the hook

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2026

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should align the TreeView and TableView onAction's in the stories so there is less confusion

@snowystinger snowystinger added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 21c4dfb Apr 13, 2026
30 checks passed
@snowystinger snowystinger deleted the revert_9875 branch April 13, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants