Skip to content

fix: support CSS logical properties for Tabs animations#9951

Merged
yihuiliao merged 2 commits into
adobe:mainfrom
SupaSeeka:fix/tab-panels-logical-properties
Apr 21, 2026
Merged

fix: support CSS logical properties for Tabs animations#9951
yihuiliao merged 2 commits into
adobe:mainfrom
SupaSeeka:fix/tab-panels-logical-properties

Conversation

@SupaSeeka
Copy link
Copy Markdown
Contributor

Closes #9949

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Run yarn jest packages/react-aria-components/test/Tabs.test.js

🧢 Your Project:

University coursework

@github-actions github-actions Bot added the RAC label Apr 20, 2026
Copy link
Copy Markdown
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good! do you mind signing the CLA? aftewards, you might need to close and re-open the PR for the check to run again

@SupaSeeka
Copy link
Copy Markdown
Contributor Author

Hello, I have signed the CLA, and will close and re-open the PR.

@SupaSeeka SupaSeeka closed this Apr 21, 2026
@SupaSeeka SupaSeeka reopened this Apr 21, 2026
@yihuiliao yihuiliao changed the title Fix TabPanels height animation not working with CSS logical properties fix: support CSS logical properties for Tabs animations Apr 21, 2026
@yihuiliao yihuiliao added this pull request to the merge queue Apr 21, 2026
Merged via the queue into adobe:main with commit abb9082 Apr 21, 2026
29 checks passed
@yihuiliao yihuiliao added the no testing Does not require manual testing during testing session label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no testing Does not require manual testing during testing session RAC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabPanels height animation does not work with CSS logical properties (block-size/inline-size)

3 participants