Skip to content

fix(S2): adjust Menu/Picker/ComboBox item transition to prevent background color transition#9953

Merged
reidbarber merged 2 commits into
mainfrom
remove-hover-transition
Apr 21, 2026
Merged

fix(S2): adjust Menu/Picker/ComboBox item transition to prevent background color transition#9953
reidbarber merged 2 commits into
mainfrom
remove-hover-transition

Conversation

@reidbarber
Copy link
Copy Markdown
Member

@reidbarber reidbarber commented Apr 20, 2026

Adjusts the S2 Menu, Picker, and ComboBox item styles to where the default transition (containing 150ms duration) does not apply to the background color, but still applies to transform (for press scaling).

From a UX perspective, this was making these components feel laggy/unresponsive when moving the cursor between items quickly. Open to feedback for this, just wanted to get up a PR for people to try out.

Before After
before-removing-transitions.mov
after-removing-transitions.mov

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

On an S2 Menu, Picker, or ComboBox and move your cursor quickly between items. Observe the behavior difference between production (it should feel snappier now).

🧢 Your Project:

@github-actions github-actions Bot added the S2 label Apr 20, 2026
@reidbarber reidbarber changed the title fix(S2): adjust Menu/Picker transition to prevent background color tr… fix(S2): adjust Menu/Picker/Combobox transition to prevent background color transition Apr 20, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 20, 2026

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels much better

@reidbarber reidbarber changed the title fix(S2): adjust Menu/Picker/Combobox transition to prevent background color transition fix(S2): adjust Menu/Picker/Combobox item transition to prevent background color transition Apr 20, 2026
@reidbarber reidbarber changed the title fix(S2): adjust Menu/Picker/Combobox item transition to prevent background color transition fix(S2): adjust Menu/Picker/ComboBox item transition to prevent background color transition Apr 20, 2026
Copy link
Copy Markdown
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree that it does feel better, but wondering how we landed on this transition to begin with and if it was a specific spec from Spectrum

@reidbarber
Copy link
Copy Markdown
Member Author

wondering how we landed on this transition to begin with and if it was a specific spec from Spectrum

I couldn't find any definitions anywhere. I think we may have used defaults that we had in S1.

@reidbarber reidbarber added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit c67ecf2 Apr 21, 2026
32 checks passed
@reidbarber reidbarber deleted the remove-hover-transition branch April 21, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants