fix(S2): adjust Menu/Picker/ComboBox item transition to prevent background color transition#9953
Merged
Conversation
|
Build successful! 🎉 |
yihuiliao
approved these changes
Apr 21, 2026
Member
yihuiliao
left a comment
There was a problem hiding this comment.
i agree that it does feel better, but wondering how we landed on this transition to begin with and if it was a specific spec from Spectrum
devongovett
approved these changes
Apr 21, 2026
Member
Author
I couldn't find any definitions anywhere. I think we may have used defaults that we had in S1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the S2 Menu, Picker, and ComboBox item styles to where the default transition (containing 150ms duration) does not apply to the background color, but still applies to
transform(for press scaling).From a UX perspective, this was making these components feel laggy/unresponsive when moving the cursor between items quickly. Open to feedback for this, just wanted to get up a PR for people to try out.
before-removing-transitions.mov
after-removing-transitions.mov
✅ Pull Request Checklist:
📝 Test Instructions:
On an S2 Menu, Picker, or ComboBox and move your cursor quickly between items. Observe the behavior difference between production (it should feel snappier now).
🧢 Your Project: