fix: layout shift in s2 modal docs#9956
Merged
Merged
Conversation
yihuiliao
approved these changes
Apr 21, 2026
snowystinger
approved these changes
Apr 22, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
lgtm, thanks for fixing that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes layout shift in https://react-aria.adobe.com/Modal#sheet, by preventing overflow on the overlay itself. The overflow is caused by the modal transformation adding a horizontal scrollbar, which then in turn causes a vertical scrollbar on the root element, causing the layout to shift horizontally. Also adds a story so the gutter addition can be regression tested in the future.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: