fix(Collections): handle falsy keys properly#9993
Merged
Merged
Conversation
|
Build successful! 🎉 |
yihuiliao
previously approved these changes
Apr 28, 2026
LFDanLu
reviewed
Apr 28, 2026
Member
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, but mind adding some tests around rows with falsy keys attached to them so we don't regress in the future?
|
Build successful! 🎉 |
LFDanLu
approved these changes
Apr 28, 2026
snowystinger
approved these changes
Apr 28, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
That was a lot of places, we really need a lint rule or ts plugin to catch those more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9991
In several places we were treating a key of
0or""as missing due to checking truthiness instead of nullishness.✅ Pull Request Checklist:
📝 Test Instructions:
Unit tests should cover.
🧢 Your Project: