Skip to content

feat: add mode-scoped dispatcher skills for cloud and 6.5lts#6

Merged
abhishekgarg18 merged 9 commits intoadobe:betafrom
abhishekgarg18:feat/aem-dispatcher-skills
Mar 12, 2026
Merged

feat: add mode-scoped dispatcher skills for cloud and 6.5lts#6
abhishekgarg18 merged 9 commits intoadobe:betafrom
abhishekgarg18:feat/aem-dispatcher-skills

Conversation

@abhishekgarg18
Copy link
Copy Markdown
Collaborator

@abhishekgarg18 abhishekgarg18 commented Mar 4, 2026

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@abhishekgarg18 abhishekgarg18 force-pushed the feat/aem-dispatcher-skills branch 11 times, most recently from 780570d to 8a38ee5 Compare March 5, 2026 22:40
@abhishekgarg18 abhishekgarg18 force-pushed the feat/aem-dispatcher-skills branch from 8a38ee5 to e766cec Compare March 5, 2026 22:48
@abhishekgarg18 abhishekgarg18 changed the title feat: add mode-scoped dispatcher skills for cloud and 6.5lts [WIP - DO NOT MERGE] feat: add mode-scoped dispatcher skills for cloud and 6.5lts Mar 9, 2026
Copy link
Copy Markdown
Collaborator

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still learning about skills packaging, so only two high-level questions from me

  • is it intended to have 'skills' twice in the path? ( e.g. skills/aem/cloud-service/skills/dispatcher )
  • will the skills/aem/shared/reference/ files be resolved when only a subset of the skills are installed, e.g. npx skills add https://github.com/adobe/skills/tree/main/skills/aem/cloud-service/skills/dispatcher --all ?

@abhishekgarg18
Copy link
Copy Markdown
Collaborator Author

@rombert

  1. Yes — that duplication is intentional and matches the existing EDS skill layout we followed for parity. The first skills/ is the repo-level grouping (the mono-repo’s top folder), while the second skills/ scopes the product/component subtree and contains the actual skill implementation. We kept this structure so the new skills remain consistent with existing repos and tool expectations; flattening it would break parity and make upgrades/migrations more error-prone.
Screenshot 2026-03-11 at 12 12 47 PM
  1. Yes, you are right, these are not installed, we either have to create these as seprate skills (but that defeats the purpose, here), or make skills self contained, so i have made these self contained.

@abhishekgarg18 abhishekgarg18 changed the base branch from main to beta March 11, 2026 08:03
@abhishekgarg18
Copy link
Copy Markdown
Collaborator Author

abhishekgarg18 commented Mar 11, 2026

updated the base to @beta branch

Copy link
Copy Markdown
Collaborator

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @abhishekgarg18 . Feel free to merge if ready (but please adjust the PR title :-) )

@abhishekgarg18 abhishekgarg18 changed the title [WIP - DO NOT MERGE] feat: add mode-scoped dispatcher skills for cloud and 6.5lts feat: add mode-scoped dispatcher skills for cloud and 6.5lts Mar 12, 2026
@abhishekgarg18 abhishekgarg18 merged commit c385337 into adobe:beta Mar 12, 2026
2 checks passed
@abhishekgarg18 abhishekgarg18 deleted the feat/aem-dispatcher-skills branch March 12, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants