Conversation
purplecabbage
left a comment
There was a problem hiding this comment.
This looks good, I assume this is generated, there is so much of it ... I looked at a few spots and made a couple notes. These are probably issues with bad docs.
Bigger question: How do we maintain all of this given that implementation will change, apis will change, features will change?
|
|
||
| | Runtime | Node.js version | Status | | ||
| | --- | --- | --- | | ||
| | nodejs:24 | 24.x | Available on Stage only | |
There was a problem hiding this comment.
'Stage' is an Adobe internal environment. Assuming this skill is accessible externally we should remove this, or elaborate more on what Stage is and who/when/where to use it.
There was a problem hiding this comment.
fixed in latest PR udate.
There was a problem hiding this comment.
@purplecabbage Regarding your question - "How do we maintain all of this given that implementation will change, apis will change, features will change?" - I think we will have to keep this up to date as the App Builder ecosystem evolves. What are the areas you see are still evolving and probably change often? The developer console project creation is something that is going to be added soon to the skills. I Will reach out to discuss more in that area.
| When `require-adobe-auth: true` is set, the Experience Cloud shell injects the user's IMS token. Access it via: | ||
|
|
||
| ```javascript | ||
| const token = params.__ow_headers.authorization.replace('Bearer ', ''); |
There was a problem hiding this comment.
utils.js has a helper which does a bit more than this:
function getBearerToken (params) {
if (params.__ow_headers &&
params.__ow_headers.authorization &&
params.__ow_headers.authorization.startsWith('Bearer ')) {
return params.__ow_headers.authorization.substring('Bearer '.length)
}
return undefined
}
There was a problem hiding this comment.
fixed in latest PR udate.
| Action URLs follow the pattern: | ||
|
|
||
| ``` | ||
| https://<namespace>.adobeioruntime.net/api/v1/web/<package>/<action-name> |
There was a problem hiding this comment.
fixed in latest PR udate.
shsteimer
left a comment
There was a problem hiding this comment.
Overall, I think this looks good to me. I'm not an App Buillder expert, so made no real attempt to review the details, but the structure, etc. I like.
A few thoughts, don't think these need to be immediate blockers, but that I think we should eventually resolve:
README.mdis getting too big for my tastes. I think eventually this should be consolidated to just a core set of what you need to know, maybe with a table or reference doc(s) listing all the specific plugins/skills/etc. that are available. Listing every possible install command and the full entire project tree seems like overkill to me. We can of course add other reference docs for specific products/areas as needed, but having it all in the README I don't love.- I like the
_shared/concept, but worry about how this works in practice. I think there should be a note somewhere that individual skill install is not supported because you need that shared reference material.
|
@shsteimer I will discuss your comments on README.md with the team internally. I agree with you that it has scope for improvement. For the _shared concept, I will have a note added in my next skills update. Thanks for the review. |
|
Great work on this! We at App Builder team have been independently exploring App Builder skills for Claude Code and there's strong complementarity between the two efforts. We have three skills focused on the high-level developer journey:
Repo: https://github.com/OneAdobe/app-builder-skills Would be great to collaborate and consolidate these into a single comprehensive collection. Happy to discuss how to combine — feel free to reach out or take a look at our repo. cc @pru55e11 |
Agent skills for App Builder create, test and deploy use cases.
Description
Adobe App Builder agent skills maintained in this repository.Each skill packages instructions, references, and helper assets for a focused App Builder workflow.
Motivation and Context
How Has This Been Tested?
These skills have been tested manually and also by creating evals for each test case and validated them using the Copilot CLI.
Screenshots (if appropriate):
Types of changes
Checklist: