feat: add PATCH /plg/onboard/:onboardingId for waitlist bypass#2153
Merged
anshulk-public merged 22 commits intomainfrom Apr 8, 2026
Merged
feat: add PATCH /plg/onboard/:onboardingId for waitlist bypass#2153anshulk-public merged 22 commits intomainfrom
anshulk-public merged 22 commits intomainfrom
Conversation
Admin-only endpoint for ESEs to review and bypass waitlisted PLG onboardings. Supports 3 waitlist scenarios: - DOMAIN_ALREADY_ONBOARDED_IN_ORG: offboards old domain, re-runs flow - AEM_SITE_CHECK: ESE provides rumHost, derives config, re-runs flow - DOMAIN_ALREADY_ASSIGNED: offboards current record, runs flow under existing org Changes: - Add update controller method with all scenario logic - Add isBypassed() guard in performAsoPlgOnboarding() for AEM check - Add deriveCheckKey() to auto-detect waitlist reason - Add presetRumHost param to derive AEM CS/EDS config from rumHost - Add REVIEW_REASONS and REVIEW_DECISIONS constants - Update DTO to include reviews field - Register PATCH route and required capabilities - Add OpenAPI spec for PATCH endpoint - Add unit tests and integration test seeds Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…mage - Update @adobe/spacecat-shared-data-access to 3.47.0 (INACTIVE status, REVIEW_DECISIONS, reviews field) - Update IT docker-compose image to mysticat-data-service:v1.56.0 (reviews column, INACTIVE enum) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This PR will trigger a minor release when merged. |
Kanishkavijay39
approved these changes
Apr 8, 2026
solaris007
pushed a commit
that referenced
this pull request
Apr 8, 2026
# [1.426.0](v1.425.0...v1.426.0) (2026-04-08) ### Features * add PATCH /plg/onboard/:onboardingId for waitlist bypass ([#2153](#2153)) ([e9ff730](e9ff730))
Member
|
🎉 This PR is included in version 1.426.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
PATCH /plg/onboard/:onboardingIdendpoint that allows ESEs (Experience Solutions Engineers) to review and bypass waitlisted PLG onboarding records, with a mandatory justification for full audit traceability. Also extendsPOST /plg/onboardto allow admin callers to onboard on behalf of any IMS org.Supported bypass scenarios:
DOMAIN_ALREADY_ONBOARDED_IN_ORG— offboards the previously onboarded domain (sets itINACTIVE) and re-runs the onboarding flow for the new domainAEM_SITE_CHECK— ESE provides arumHostoverride to satisfy the AEM site check and re-runs the flowDOMAIN_ALREADY_ASSIGNED— offboards the conflicting record and runs the flow under the existing org that owns the domainOther changes:
reviewsfield on thePlgOnboardingrecord (reason,decision,reviewedBy,reviewedAt,justification)isBypassed()now checks only the most recent review — so bypassing a second block (e.g.DOMAIN_ALREADY_ONBOARDED_IN_ORG) does not silently carry forward an earlier AEM bypass without arumHostPOST /plg/onboardwith an explicitimsOrgIdto onboard on behalf of any orgmysticat-data-service:v1.56.0(migration:reviewsJSONB column +INACTIVEenum value)Test plan
npx mocha test/controllers/plg/plg-onboarding.test.js— 136 passingnpx mocha --require test/it/postgres/harness.js --timeout 30000 'test/it/postgres/**/*.test.js'— 25 passingplg-onboarding.jsnpx mocha test/routes/index.test.js— passingPATCHendpoint with each bypass scenario via admin API key🤖 Generated with Claude Code
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
Thanks for contributing!