docs: correct Preflight TTL mechanism in ADR 002

[GeezerPelletier]

Corrects the TTL/expiry description in ADR 002 to reflect the actual implementation.

withRecordExpiry is a DynamoDB-era SchemaBuilder helper marked postgrestIgnore in the v3 PostgreSQL layer - it never writes to the database. The preflights table has no record_expires_at column. Cleanup is handled by ON DELETE CASCADE on async_job_id.

Companion to:

• mysticat-data-service PR: https://github.com/adobe/mysticat-data-service/pull/622
• spacecat-shared PR: feat(data-access): add Preflight entity (SITES-45417) spacecat-shared#1622

Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[MysticatBot-Dev]

Hey @GeezerPelletier,

Strengths

• Corrects ADR 002 to reflect the actual PostgreSQL implementation rather than leaving DynamoDB-era assumptions in the design record (docs/decisions/002-preflight-api-rest-redesign.md:305-309)
• Clear explanation of the real expiry mechanism (ON DELETE CASCADE) and why withRecordExpiry is a no-op in the v3 layer
• Well-scoped companion PR that keeps documentation in sync with the data-service and shared library changes

Assessment

Ready to merge? Yes
Reasoning: This is a factual correction to an ADR, aligning the documented TTL mechanism with the actual PostgreSQL implementation. The change is accurate, well-explained, and ships alongside the companion PRs that established the correct behavior. CI is green.

---

_{Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 1m 22s | Cost: $0.50 | Commit: 269e96bac61d0060faa803117d8e8c22035cbd90
If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[github-actions]

This PR will trigger no release when merged.

[solaris007]

🎉 This PR is included in version 1.513.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀