-
Notifications
You must be signed in to change notification settings - Fork 14
feat: introduce AMS promise token #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const promiseBasedTypes = [AUTHORING_TYPES.CS, AUTHORING_TYPES.CS_CW, AUTHORING_TYPES.AMS]; | ||
| if (site | ||
| && (CS_TYPES.includes(site.getAuthoringType()) | ||
| && (promiseBasedTypes.includes(site.getAuthoringType()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, we will now have to make sure that the authoringType for AMS customer sites is set to- authoringType: ams, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, I opened another PR for this, to make sure sites can be onboarded like that: adobe/spacecat-api-service#1493
|
Also, to compute the external ids we have to add AMS here- spacecat-shared/packages/spacecat-shared-data-access/src/models/site/site.model.js Line 42 in 47f44b8
|
No as for the AMS author URL it's not possible to generate external ownser and site id |
Ah okay, my bad. Is it because this is the URL format for AMS https://author-aso-prod-topology-b80.adobecqms.net/aem/start.html? |
|
This PR will trigger a minor release when merged. |
# [@adobe/spacecat-shared-ims-client-v1.11.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-ims-client-v1.10.1...@adobe/spacecat-shared-ims-client-v1.11.0) (2025-11-14) ### Features * introduce AMS promise token ([#1123](#1123)) ([324688e](324688e))
|
🎉 This PR is included in version @adobe/spacecat-shared-ims-client-v1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@adobe/spacecat-shared-utils-v1.73.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.72.1...@adobe/spacecat-shared-utils-v1.73.0) (2025-11-14) ### Features * introduce AMS promise token ([#1123](#1123)) ([324688e](324688e))
|
🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.73.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Introduce AMS authoring type and obtain promise token in that case