Skip to content

Conversation

@dzehnder
Copy link
Contributor

Introduce AMS authoring type and obtain promise token in that case

const promiseBasedTypes = [AUTHORING_TYPES.CS, AUTHORING_TYPES.CS_CW, AUTHORING_TYPES.AMS];
if (site
&& (CS_TYPES.includes(site.getAuthoringType())
&& (promiseBasedTypes.includes(site.getAuthoringType())
Copy link
Contributor

@radhikagpt1208 radhikagpt1208 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, we will now have to make sure that the authoringType for AMS customer sites is set to- authoringType: ams, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, I opened another PR for this, to make sure sites can be onboarded like that: adobe/spacecat-api-service#1493

@radhikagpt1208
Copy link
Contributor

Also, to compute the external ids we have to add AMS here-

&& (authoringType === authoringTypes.CS || authoringType === authoringTypes.CS_CW)) {

@dzehnder
Copy link
Contributor Author

Also, to compute the external ids we have to add AMS here-

&& (authoringType === authoringTypes.CS || authoringType === authoringTypes.CS_CW)) {

No as for the AMS author URL it's not possible to generate external ownser and site id

@radhikagpt1208
Copy link
Contributor

Also, to compute the external ids we have to add AMS here-

&& (authoringType === authoringTypes.CS || authoringType === authoringTypes.CS_CW)) {

No as for the AMS author URL it's not possible to generate external ownser and site id

Ah okay, my bad. Is it because this is the URL format for AMS https://author-aso-prod-topology-b80.adobecqms.net/aem/start.html?

@github-actions
Copy link

This PR will trigger a minor release when merged.

@dzehnder dzehnder merged commit 324688e into main Nov 14, 2025
7 checks passed
@dzehnder dzehnder deleted the ams-preflight-support branch November 14, 2025 13:24
solaris007 pushed a commit that referenced this pull request Nov 14, 2025
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-ims-client-v1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

solaris007 pushed a commit that referenced this pull request Nov 14, 2025
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-utils-v1.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants