Skip to content

Button Breaking Changes - #649

Merged
jianliao merged 12 commits into
masterfrom
button-rsp-v3
Apr 29, 2020
Merged

Button Breaking Changes#649
jianliao merged 12 commits into
masterfrom
button-rsp-v3

Conversation

@lazd

@lazd lazd commented Mar 17, 2020

Copy link
Copy Markdown
Member

Description

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Figure out if Action Group Compact needs to apply to quiet Action Buttons at all
  • This pull request is ready to merge.

lazd added 8 commits April 23, 2020 13:25
BREAKING CHANGE: Tool button has been removed
fix: correct Quiet Emphasized Action Button
BREAKING CHANGE: Button group no longer supports Action Button, just normal buttons
BREAKING CHANGE: Margins have been removed from adjacent buttons. Use ButtonGroup instead.
@lazd
lazd marked this pull request as ready for review April 27, 2020 17:45
@lazd lazd changed the title WIP: Button Breaking Changes Button Breaking Changes Apr 27, 2020
@jianliao

jianliao commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

@lazd Updated the VRT scenarios config file to include the new component actiongroup.

@jianliao

jianliao commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

VRT now covered actiongroup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants