Skip to content

build: update node dependency from v18 to v20#2671

Merged
castastrophe merged 2 commits intomainfrom
build-node-v20-update
Apr 26, 2024
Merged

build: update node dependency from v18 to v20#2671
castastrophe merged 2 commits intomainfrom
build-node-v20-update

Conversation

@castastrophe
Copy link
Copy Markdown
Contributor

@castastrophe castastrophe commented Apr 18, 2024

Description

Update node v18 to v20.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Setup:

  1. nvm use
  2. yarn install

Check for regressions:

  • yarn build
  • yarn start

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added blocked See description and comments for what is blocking this issue build Issues associated with the build process; often a refactor do not merge A flag for a branch indicating it should not be merged. labels Apr 18, 2024
@castastrophe castastrophe self-assigned this Apr 18, 2024
@castastrophe castastrophe force-pushed the build-node-v20-update branch from 8a0f9d0 to b6533ff Compare April 18, 2024 19:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

🚀 Deployed on https://pr-2671--spectrum-css.netlify.app

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2024

File metrics

Summary

Total size: 4.57 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the build-node-v20-update branch from b6533ff to 5a82b0f Compare April 18, 2024 20:25
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 838afaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@spectrum-css/preview Major
@spectrum-css/generator Major
@spectrum-tools/documentation Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@castastrophe castastrophe force-pushed the build-node-v20-update branch 5 times, most recently from d21ea2d to 70dc362 Compare April 24, 2024 14:32
@castastrophe castastrophe marked this pull request as ready for review April 24, 2024 14:36
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review and removed blocked See description and comments for what is blocking this issue do not merge A flag for a branch indicating it should not be merged. labels Apr 24, 2024
@castastrophe castastrophe requested a review from pfulton April 24, 2024 14:39
@castastrophe castastrophe mentioned this pull request Apr 25, 2024
9 tasks
Copy link
Copy Markdown
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me locally!

The only issue that I found is that https://pr-2671--spectrum-css.netlify.app/preview doesn't seem to be working, and clicking on "Component Preview" leads me to a Chromatic url:
image

I know we had that issue before, did we find what was causing it then?

@castastrophe
Copy link
Copy Markdown
Contributor Author

This works well for me locally!

The only issue that I found is that https://pr-2671--spectrum-css.netlify.app/preview doesn't seem to be working, and clicking on "Component Preview" leads me to a Chromatic url: image

I know we had that issue before, did we find what was causing it then?

That's correct and expected behavior. If Chromatic builds, we use that link for preview instead of re-building locally. If the VRT step is skipped, it builds it locally so you get a /preview result.

@castastrophe castastrophe force-pushed the build-node-v20-update branch from 70dc362 to ec6bf7b Compare April 26, 2024 13:40
@castastrophe castastrophe merged commit 9130dd9 into main Apr 26, 2024
@castastrophe castastrophe deleted the build-node-v20-update branch April 26, 2024 15:54
This was referenced Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues associated with the build process; often a refactor ready-for-review run_vrt For use on PRs looking to kick off VRT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants