Skip to content

chore(vscode-settings): remove deprecated property; disable postcss validate #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore(vscode-settings): remove deprecated property; disable postcss validate #3325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@
"postcss": "css"
},
"eslint.format.enable": true,
"eslint.packageManager": "yarn",
Copy link
Contributor

@castastrophe castastrophe Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Member Author

@cdransf cdransf Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it — but VS Code indicated that it's now handled by default and the setting has been deprecated.

Copy link
Member Author

@cdransf cdransf Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/microsoft/vscode-eslint/blob/fa396e45eb25087950c81c9a9f9eb6f7d1f2818f/README.md?plain=1#L218

"eslint.useESLintClass": true,
"files.associations": {
"*.css": "postcss"
Expand Down Expand Up @@ -167,6 +166,7 @@
}
],
"js/ts.implicitProjectConfig.experimentalDecorators": true,
"postcss.validate": false,
Copy link
Contributor

@castastrophe castastrophe Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

"prettier.configPath": ".prettierrc",
"prettier.ignorePath": ".prettierignore",
"prettier.prettierPath": "node_modules/prettier",
Expand Down
Loading