Merged
Conversation
castastrophe
approved these changes
Jan 6, 2025
Contributor
Author
|
🚀 Deployed on https://pr-3482--spectrum-css.netlify.app |
Contributor
Author
File metricsSummaryTotal size: 4.27 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
|
@castastrophe may we please get the same fix on the s2-foundations release so that I can use it in SWC? 🥺 |
Contributor
|
@Rocss s2-foundations is regularly rebased against main so all the fixes end up in there but it takes some effort to pull in the foundations releases into SWC and validate regressions. It's in process but might not be as fast as a normal bug fix because the foundations work is in a pre-state. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@spectrum-css/slider@5.5.1
Patch Changes
2c66a87Thanks @5t3ph! - fix(slider): Limit the slider label width to its intrinsic size instead of taking up full-width to prevent accidental activation on mobile.