Skip to content

Conversation

@GarthDB
Copy link
Member

@GarthDB GarthDB commented Nov 19, 2025

Summary

This PR removes unused JSON files from both visualizer directories that were never actually used by the applications.

Details

  • Removed: docs/visualizer/public/json/ directory (8 JSON files)
  • Removed: docs/s2-visualizer/public/json/ directory (8 JSON files)
  • Total: 16 files, 21,852 lines removed

Rationale

Both visualizers fetch token data remotely from GitHub at runtime via XHR requests:

  • docs/visualizer fetches from: https://raw.githubusercontent.com/adobe/spectrum-design-data/s1-legacy/packages/tokens/
  • docs/s2-visualizer fetches from: https://raw.githubusercontent.com/adobe/spectrum-design-data/main/packages/tokens/

The local JSON files were:

  • Never referenced by the application code
  • Not copied to the build output directories (/site is gitignored)
  • Not updated since their initial commits
  • Taking up unnecessary space in the repository

Testing

The visualizers continue to work as expected, fetching data from the remote GitHub URLs at runtime.

The visualizers fetch token data remotely from GitHub at runtime via XHR

requests, so these local JSON files in docs/visualizer/public/json and

docs/s2-visualizer/public/json were never used. They were not copied to

the build output and have not been updated since their initial commits.
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

⚠️ No Changeset found

Latest commit: 9c821aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Nov 19, 2025

Run report for 9c821aaf

Total time: 14.2s | Comparison time: 17.9s | Estimated savings: 3.7s (20.7% faster)

Action Time Status Info
⬛️ SetupProto(0.51.4) 0.1ms Skipped
🟩 SyncWorkspace 6.7ms Passed
🟩 SyncProject(visualizer) 0.4ms Passed
🟩 SyncProject(s2-visualizer) 0.4ms Passed
⬛️ SetupToolchain(node:~20.12) 1.2s Skipped
🟩 InstallWorkspaceDeps(node:~20.12) 7.6s Passed
🟩 RunTask(s2-visualizer:typescript) 3s Passed
🟩 RunTask(visualizer:typescript) 3s Passed
🟩 RunTask(s2-visualizer:build) 2.3s Passed
🟩 RunTask(visualizer:build) 2.3s Passed
Touched files
docs/s2-visualizer/public/json/color-aliases.json
docs/s2-visualizer/public/json/color-component.json
docs/s2-visualizer/public/json/color-palette.json
docs/s2-visualizer/public/json/components/action-button.json
docs/s2-visualizer/public/json/layout-component.json
docs/s2-visualizer/public/json/layout.json
docs/s2-visualizer/public/json/semantic-color-palette.json
docs/s2-visualizer/public/json/typography.json
docs/visualizer/public/json/color-aliases.json
docs/visualizer/public/json/color-component.json
docs/visualizer/public/json/color-palette.json
docs/visualizer/public/json/components/action-button.json
docs/visualizer/public/json/layout-component.json
docs/visualizer/public/json/layout.json
docs/visualizer/public/json/semantic-color-palette.json
docs/visualizer/public/json/typography.json

@GarthDB GarthDB merged commit b134ce0 into main Nov 19, 2025
4 checks passed
@GarthDB GarthDB deleted the chore/remove-unused-visualizer-json-files branch November 19, 2025 20:12
GarthDB added a commit that referenced this pull request Nov 19, 2025
Resolved conflicts by accepting deletion of unused JSON files from PR #640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants