Skip to content

fix(tokens): restore PR #749 manual work and studio sync (icon sizing)#753

Merged
GarthDB merged 15 commits intomainfrom
restore-pr-749-sync
Mar 25, 2026
Merged

fix(tokens): restore PR #749 manual work and studio sync (icon sizing)#753
GarthDB merged 15 commits intomainfrom
restore-pr-749-sync

Conversation

@GarthDB
Copy link
Copy Markdown
Member

@GarthDB GarthDB commented Mar 25, 2026

Summary

Restores manual commits that were overwritten when sync-s2 force-pushed PR #749 after spectrum-tokens-studio-data PR #299, and keeps the post-299 token updates.

What was restored (from local pr-749-sync)

  • Semantic layout tokens moved to layout.json, deprecation metadata, descriptions, schema updates (description / renamed on token-type schemas)
  • Flattened help-text-top-to-workflow-icon-* alias scale-sets
  • Component schema performance test thresholds (500ms) for CI stability
  • Changeset .changeset/20260324-5de7c01e.md

Integrated from latest sync (54093a3)

  • workflow-icon-* semantic tokens in layout.json
  • ui-icon-* scale-set tokens in layout-component.json (with component: "ui-icon" for validation)

Notes

Made-with: Cursor

Made with Cursor

GarthDB and others added 7 commits March 24, 2026 17:15
Add deprecated_comment and renamed metadata to all 540 deprecated layout
tokens so consumers have clear migration paths. Add description field to
99 new semantic tokens documenting their purpose. Add description property
to all token-type JSON schemas (aligns with DTCG $description). Add renamed
property to set-type schemas. Move semantic layout tokens to layout.json.
Regenerate validation snapshot and update changeset.

Co-authored-by: Nate Baldwin <nate.baldwin@gmail.com>
Made-with: Cursor
…e-set

These 4 tokens had identical desktop/mobile alias values wrapped in an
unnecessary scale-set structure. Flatten to simple alias tokens since
there is no per-platform variation.

Made-with: Cursor
…ability

The getSchemaFile and concurrent getSchemaBySlug performance tests had
200ms thresholds that were too tight for CI runners under load, causing
flaky failures (e.g. 207.50ms). Increase to 500ms to accommodate
runner variability while still catching genuine regressions.

Made-with: Cursor
…ability

The getSchemaFile and concurrent getSchemaBySlug performance tests had
200ms thresholds that were too tight for CI runners under load, causing
flaky failures (e.g. 207.50ms). Increase to 500ms to accommodate
runner variability while still catching genuine regressions.

Made-with: Cursor
Restore manual layout token metadata, schema updates, and changeset from
pr-749-sync. Keep workflow-icon-* in layout.json and ui-icon-* scale-sets
(with component field) from the post-299 sync.

Made-with: Cursor
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 25, 2026

🦋 Changeset detected

Latest commit: f2ff704

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@adobe/spectrum-tokens Minor
@adobe/token-diff-generator Patch
s2-tokens-viewer Patch
markdown-generator Patch
@adobe/spectrum-design-data-mcp Patch
token-csv-generator Patch
token-changeset-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Copy Markdown
Member Author

GarthDB commented Mar 25, 2026

Run report for f2ff704f

Total time: 1m 20s | Comparison time: 2m 23s | Estimated savings: 1m 3s (44.0% faster)

Action Time Status Info
⬛️ SetupProto(0.51.4) 0.1ms Skipped
🟩 SyncWorkspace 6.9ms Passed
🟩 SyncProject(sdk) 0.5ms Passed
🟩 SyncProject(componentSchemas) 0.5ms Passed
🟩 SyncProject(optimized-diff) 0.3ms Passed
🟩 SyncProject(spectrum-diff-core) 0.4ms Passed
🟩 SyncProject(designDataSpec) 0.3ms Passed
🟩 SyncProject(design-system-registry) 0.3ms Passed
🟩 SyncProject(tokens) 0.5ms Passed
🟩 SyncProject(token-diff-generator) 0.4ms Passed
🟩 SyncProject(viewer) 0.3ms Passed
🟩 SyncProject(markdown-generator) 0.3ms Passed
🟩 SyncProject(site) 0.2ms Passed
⬛️ SetupToolchain(node:20.17.0) 1.4s Skipped
🟩 InstallWorkspaceDeps(node:20.17.0) 10.4s Passed
🟩 RunTask(designDataSpec:check) 147.1ms Passed
🟩 RunTask(tokens:buildManifest) 296ms Passed
🟩 RunTask(design-system-registry:validate) 306.2ms Passed
🟩 SetupToolchain(rust:1.85.0) 13.7s Passed
🟩 RunTask(design-system-registry:test) 1.7s Passed
And 18 more...
Expanded report
Action Time Status Info
🟩 RunTask(site:generateToolsPage) 2.8s Passed
🟩 RunTask(componentSchemas:test) 5.5s Passed
🟩 InstallWorkspaceDeps(rust:1.85.0, sdk) 1.3s Passed
🟩 RunTask(token-diff-generator:test) 9.8s Passed
🟩 RunTask(token-diff-generator:ci) 45.8ms Passed
🟩 RunTask(token-diff-generator:diff) 379.1ms Passed
🟩 RunTask(sdk:build) 43.9s Passed
🟩 RunTask(tokens:validateDesignData) 564.6ms Passed
🟩 RunTask(tokens:verifyDesignDataSnapshot) 820ms Passed
🟩 RunTask(tokens:buildTokens) 1m 1s Passed
🟩 RunTask(tokens:build) 13.3ms Passed
🟩 RunTask(viewer:prepare) 145.5ms Passed
🟩 RunTask(viewer:export) 60.4ms Passed
🟩 RunTask(markdown-generator:generate) 383.4ms Passed
🟩 RunTask(site:copyContent) 92ms Passed
🟩 RunTask(tokens:test) 4.4s Passed
🟩 RunTask(site:build) 4.2s Passed
🟩 RunTask(site:export) 8ms Passed
Touched files
.changeset/20260324-5de7c01e.md
.changeset/20260325-normalize-deprecation.md
.github/actions/diff-pr-comment/action.yml
.github/actions/generate-diff/action.yml
.github/workflows/token-diff-pr-comment.yml
docs/site/public/schemas/token-types/alias.json
docs/site/public/schemas/token-types/color-set.json
docs/site/public/schemas/token-types/color.json
docs/site/public/schemas/token-types/dimension.json
docs/site/public/schemas/token-types/drop-shadow.json
docs/site/public/schemas/token-types/font-family.json
docs/site/public/schemas/token-types/font-size.json
docs/site/public/schemas/token-types/font-style.json
docs/site/public/schemas/token-types/font-weight.json
docs/site/public/schemas/token-types/gradient-stop.json
docs/site/public/schemas/token-types/multiplier.json
docs/site/public/schemas/token-types/opacity.json
docs/site/public/schemas/token-types/scale-set.json
docs/site/public/schemas/token-types/set.json
docs/site/public/schemas/token-types/system-set.json
docs/site/public/schemas/token-types/text-align.json
docs/site/public/schemas/token-types/text-transform.json
docs/site/public/schemas/token-types/token.json
docs/site/public/schemas/token-types/typography.json
packages/component-schemas/test/performance.test.js
packages/design-data-spec/schemas/token.schema.json
packages/design-system-registry/registry/token-terminology.json
packages/tokens/schemas/token-types/alias.json
packages/tokens/schemas/token-types/color-set.json
packages/tokens/schemas/token-types/color.json
packages/tokens/schemas/token-types/dimension.json
packages/tokens/schemas/token-types/drop-shadow.json
packages/tokens/schemas/token-types/font-family.json
packages/tokens/schemas/token-types/font-size.json
packages/tokens/schemas/token-types/font-style.json
packages/tokens/schemas/token-types/font-weight.json
packages/tokens/schemas/token-types/gradient-stop.json
packages/tokens/schemas/token-types/multiplier.json
packages/tokens/schemas/token-types/opacity.json
packages/tokens/schemas/token-types/scale-set.json
packages/tokens/schemas/token-types/set.json
packages/tokens/schemas/token-types/system-set.json
packages/tokens/schemas/token-types/text-align.json
packages/tokens/schemas/token-types/text-transform.json
packages/tokens/schemas/token-types/token.json
packages/tokens/schemas/token-types/typography.json
packages/tokens/snapshots/validation-snapshot.json
packages/tokens/src/layout-component.json
packages/tokens/src/layout.json
tools/diff-generator/src/lib/index.js
tools/diff-generator/src/lib/normalize-deprecation.js
tools/diff-generator/test/deprecatedToken.test.js
tools/diff-generator/test/normalizeDeprecation.test.js
tools/diff-generator/test/test-schemas/deprecation-set-level-original.json
tools/diff-generator/test/test-schemas/deprecation-top-level-updated.json

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

🎨 Token Changes Report

⚠️ This report was truncated due to GitHub comment size limits.

📋 View full report in the Actions Job Summary

Tokens Changed (671)

Original Branch: main
New Branch: restore-pr-749-sync

Newly Deprecated (540)
  • text-to-visual-50: Use semantic token base-gap-extra-small instead.
  • text-to-visual-75: Use semantic token base-gap-small instead.
  • text-to-visual-100: Use semantic token base-gap-medium instead.
  • text-to-visual-200: Use semantic token base-gap-large instead.
  • text-to-visual-300: Use semantic token base-gap-extra-large instead.
  • text-to-visual-400: Use semantic token base-gap-2x-large instead.
  • text-to-control-50: Use semantic token base-gap-extra-small instead.
  • text-to-control-75: Use semantic token base-gap-small instead.
  • text-to-control-100: Use semantic token base-gap-medium instead.
  • text-to-control-200: Use semantic token base-gap-large instead.
  • text-to-control-300: Use semantic token base-gap-extra-large instead.
  • visual-to-control-100: Use semantic token base-gap-medium instead.
  • label-to-description-0: Zero values are removed without token replacements; hardcode a zero-pixel value in implementation.
  • focus-indicator-gap: Use semantic token focus-ring-gap instead.
  • component-pill-edge-to-visual-75: Use semantic token base-padding-horizontal-small instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs
  • component-pill-edge-to-visual-100: Use semantic token base-padding-horizontal-medium instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs
  • component-pill-edge-to-visual-200: Use semantic token base-padding-horizontal-large instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs
  • component-pill-edge-to-visual-300: Use semantic token base-padding-horizontal-extra-large instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs
  • component-pill-edge-to-visual-only-75: Use semantic token base-padding-vertical-small instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs
  • component-pill-edge-to-visual-only-100: Use semantic token accessory-item-padding-medium instead. Eliminating pill-specific padding to align with Spectrum Future Foundations designs

... and 520 more items in this section. See full report link below.

Added (117)
  • accessory-gap-2x-large
  • accessory-gap-affixed-2x-large
  • accessory-gap-affixed-extra-large
  • accessory-gap-affixed-extra-small
  • accessory-gap-affixed-large
  • accessory-gap-affixed-medium
  • accessory-gap-affixed-small
  • accessory-gap-extra-large
  • accessory-gap-extra-small
  • accessory-gap-large
  • accessory-gap-medium
  • accessory-gap-small
  • accessory-item-padding-2x-small
  • accessory-item-padding-extra-large
  • accessory-item-padding-extra-small
  • accessory-item-padding-large
  • accessory-item-padding-medium
  • accessory-item-padding-small
  • banner-gap-horizontal
  • banner-gap-vertical

... and 97 more items in this section. See full report link below.

Updated (14)

Added Properties (6)
  • help-text-top-to-workflow-icon-small
    • value: {component-top-to-workflow-icon-75}
    • deprecated_comment: Replaced with component-top-to-workflow-icon-75
    • renamed: component-top-to-workflow-icon-75
    • uuid: 91cb19ef-63fc-4d98-a61e-a5f55951f656
  • help-text-top-to-workflow-icon-medium
    • value: {component-top-to-workflow-icon-100}
    • deprecated_comment: Replaced with component-top-to-workflow-icon-100
    • renamed: component-top-to-workflow-icon-100
    • uuid: d159b313-4def-493a-adcf-398e2d1fce9f
  • help-text-top-to-workflow-icon-large
    • value: {component-top-to-workflow-icon-200}
    • deprecated_comment: Replaced with component-top-to-workflow-icon-200
    • renamed: component-top-to-workflow-icon-200
    • uuid: 54cae12b-5f21-47b4-a964-6033bd025975
  • help-text-top-to-workflow-icon-extra-large
    • value: {component-top-to-workflow-icon-300}
    • deprecated_comment: Replaced with component-top-to-workflow-icon-300
    • renamed: component-top-to-workflow-icon-300
    • uuid: bec914a9-5905-40ac-bd61-a727016c1228
  • side-navigation-with-icon-second-level-edge-to-text
    • deprecated_comment: Use semantic token list-indent-medium instead.
    • renamed: list-indent-medium
  • side-navigation-with-icon-third-level-edge-to-text
    • deprecated_comment: Use semantic token list-indent-medium instead.
    • renamed: list-indent-medium
Deleted Properties (4)
  • help-text-top-to-workflow-icon-small
    • desktop.schema: -> alias.json
    • desktop.value: -> {component-top-to-workflow-icon-75}
    • desktop.uuid: -> 91cb19ef-63fc-4d98-a61e-a5f55951f656
    • desktop.deprecated_comment: -> Replaced with component-top-to-workflow-icon-75
    • desktop.renamed: -> component-top-to-workflow-icon-75
    • mobile.schema: -> alias.json
    • mobile.value: -> {component-top-to-workflow-icon-75}
    • mobile.uuid: -> 00334ebf-5706-4a97-b02c-9f41642c4795
    • mobile.deprecated_comment: -> Replaced with component-top-to-workflow-icon-75
    • mobile.renamed: -> component-top-to-workflow-icon-75
  • help-text-top-to-workflow-icon-medium
    • desktop.schema: -> alias.json
    • desktop.value: -> {component-top-to-workflow-icon-100}
    • desktop.uuid: -> d159b313-4def-493a-adcf-398e2d1fce9f
    • desktop.deprecated_comment: -> Replaced with component-top-to-workflow-icon-100
    • desktop.renamed: -> component-top-to-workflow-icon-100
    • mobile.schema: -> alias.json
    • mobile.value: -> {component-top-to-workflow-icon-100}
    • mobile.uuid: -> b690bd12-855e-444d-8b76-a7ae948e3f52
    • mobile.deprecated_comment: -> Replaced with component-top-to-workflow-icon-100
    • mobile.renamed: -> component-top-to-workflow-icon-100
  • help-text-top-to-workflow-icon-large
    • desktop.schema: -> alias.json
    • desktop.value: -> {component-top-to-workflow-icon-200}
    • desktop.uuid: -> 54cae12b-5f21-47b4-a964-6033bd025975
    • desktop.deprecated_comment: -> Replaced with component-top-to-workflow-icon-200
    • desktop.renamed: -> component-top-to-workflow-icon-200
    • mobile.schema: -> alias.json
    • mobile.value: -> {component-top-to-workflow-icon-200}
    • mobile.uuid: -> e2c40309-5b3d-485a-bafa-9015a5b751e7
    • mobile.deprecated_comment: -> Replaced with component-top-to-workflow-icon-200
    • mobile.renamed: -> component-top-to-workflow-icon-200
  • help-text-top-to-workflow-icon-extra-large
    • desktop.schema: -> alias.json
    • desktop.value: -> {component-top-to-workflow-icon-300}
    • desktop.uuid: -> bec914a9-5905-40ac-bd61-a727016c1228
    • desktop.deprecated_comment: -> Replaced with component-top-to-workflow-icon-300
    • desktop.renamed: -> component-top-to-workflow-icon-300
    • mobile.schema: -> alias.json
    • mobile.value: -> {component-top-to-workflow-icon-300}
    • mobile.uuid: -> 251c39cc-f949-4055-aecb-42fc99f9d504
    • mobile.deprecated_comment: -> Replaced with component-top-to-workflow-icon-300
    • mobile.renamed: -> component-top-to-workflow-icon-300
Updated Properties (4)
  • help-text-top-to-workflow-icon-small
    • schema: scale-set.json -> alias.json
  • help-text-top-to-workflow-icon-medium
    • schema: scale-set.json -> alias.json
  • help-text-top-to-workflow-icon-large
    • schema: scale-set.json -> alias.json
  • help-text-top-to-workflow-icon-extra-large
    • schema: scale-set.json -> alias.json

This comment was automatically generated by the token diff tool. 🤖

GarthDB added 4 commits March 25, 2026 14:46
Handle GitHub PR comment size limits by uploading full token diff reports
as a secret gist and posting a truncated summary with a link.

Made-with: Cursor
GITHUB_TOKEN lacks the gist OAuth scope so gh gist create always
fails in CI. Write the full report to GITHUB_STEP_SUMMARY and
link to the Actions run from the truncated PR comment instead.

Made-with: Cursor
Tokens deprecated at every set level (e.g. sets.desktop.deprecated and
sets.mobile.deprecated) are now treated as equivalent to top-level
deprecated during diff comparison. This prevents false "Newly Deprecated"
and "Newly Un-deprecated" reports when deprecation metadata is
restructured from set-level to top-level.

Made-with: Cursor
GarthDB and others added 4 commits March 25, 2026 16:18
Sync changeset token changes section with the latest CI diff report:
update total from 643 to 671, add 14 icon sizing tokens to Added
(103 to 117), add Updated section with help-text flattening and
side-nav deprecation metadata, fix branch reference, add PR #753
to references.

Made-with: Cursor
Add 21 token terminology entries from PR #692 (SDS-15500) to support
the semantic layout token naming taxonomy: structure, base, list,
table, container, group, drop-target, focus-ring, accessory, banner,
text, substructure, item, padding, gap, orientation, shape, uniform,
position, affixed, and size.

Co-authored-by: Nate Baldwin <nate.baldwin@gmail.com>
Made-with: Cursor
@GarthDB GarthDB merged commit a6d8f51 into main Mar 25, 2026
4 checks passed
@GarthDB GarthDB deleted the restore-pr-749-sync branch March 25, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant