-
Notifications
You must be signed in to change notification settings - Fork 235
Closed
Labels
Component: Split viewGood first issueGood for newcomersGood for newcomersNeeds discussionProposed UX or spec changes requiring discussion w/ internal teamProposed UX or spec changes requiring discussion w/ internal teama11yIssues or PRs related to accessibilityIssues or PRs related to accessibilityi18nInternationalisationInternationalisationtriageAn issue needing triageAn issue needing triage
Description
Code of conduct
- I agree to follow this project's code of conduct.
Description of issue
Follow up to the work done in #3800
The this.label attribute in sp-split-view is inconsistent with our other this.label attributes, because it sets the value internally to the code like so:
const label = this.label || this.resizable ? 'Resize the panels' : undefined;
The aria-label is set to label if it is defined, rather than this.label. Do we want this to be customisable by the user and have "Resize the panels" as a fallback option? Or is this fine as it is?
Reference:
"The splitter also has an accessible name that matches the name of the primary pane."
Metadata
Metadata
Assignees
Labels
Component: Split viewGood first issueGood for newcomersGood for newcomersNeeds discussionProposed UX or spec changes requiring discussion w/ internal teamProposed UX or spec changes requiring discussion w/ internal teama11yIssues or PRs related to accessibilityIssues or PRs related to accessibilityi18nInternationalisationInternationalisationtriageAn issue needing triageAn issue needing triage