Skip to content

[split-view]: update label attribute to be customisable  #3811

@najikahalsema

Description

@najikahalsema

Code of conduct

  • I agree to follow this project's code of conduct.

Description of issue

Follow up to the work done in #3800

The this.label attribute in sp-split-view is inconsistent with our other this.label attributes, because it sets the value internally to the code like so:

const label = this.label || this.resizable ? 'Resize the panels' : undefined;

The aria-label is set to label if it is defined, rather than this.label. Do we want this to be customisable by the user and have "Resize the panels" as a fallback option? Or is this fine as it is?

Reference:
"The splitter also has an accessible name that matches the name of the primary pane."

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: Split viewGood first issueGood for newcomersNeeds discussionProposed UX or spec changes requiring discussion w/ internal teama11yIssues or PRs related to accessibilityi18nInternationalisationtriageAn issue needing triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions