fix(split-view): update label attribute to be customisable #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
13 tasks
Contributor
Tachometer resultsChromesplit-view permalinkbasic-test
Firefoxsplit-view permalinkbasic-test
|
Rajdeepc
changed the title
Westbrook
approved these changes
Mar 14, 2024
Contributor
Westbrook
left a comment
Westbrook
left a comment
There was a problem hiding this comment.
LGTM! Catching up main and will merge is we go green. Many thanks. 🙇🏼
Westbrook
force-pushed
the
sazhou/acpc_hackathon_bug_3811
branch
from
0c7a888 to
e3317cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: fixes #3811
Adjusting the logic such that the label allows for a custom label, if it is defined
I have updated the label constant to consider this.label if it is defined. To test this out, I gave label the value of Resizable Split View Custom Label and ran on Storybook to verify that if label is defined, it overrides the default. See video:
https://github.com/adobe/spectrum-web-components/assets/55859693/e60be647-299a-4fa4-9838-0911eaa580b0
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.