feat(date-time-picker): add time field component (WIP)

.circleci/config.yml

@@ -10,7 +10,7 @@ executors:
 parameters:
     current_golden_images_hash:
         type: string
-        default: 272df076898ee35337c14698a17497e9ecc1644b
+        default: d5cfb5a524e64e6feeaa6af58dc8423dc80c0b29
     wireit_cache_name:
         type: string
         default: wireit

.vscode/settings.json

@@ -11,5 +11,6 @@
         "tools/**/*.dev.js": { "when": "$(basename).js" },
         "tools/**/*.d.ts": { "when": "$(basename).ts" },
         "**/*.test-vrt.ts": true
-    }
+    },
+    "typescript.tsdk": "node_modules/typescript/lib"
 }

CHANGELOG.md

@@ -3,6 +3,35 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [0.34.0](https://github.com/adobe/spectrum-web-components/compare/v0.33.2...v0.34.0) (2023-07-11)
+
+### Bug Fixes
+
+-   **action-button,action-menu,picker,split-button:** expand and update application of aria-\* attributes ([52c0156](https://github.com/adobe/spectrum-web-components/commit/52c015636d42f2baf1524446a0db9d5e5cfeb689))
+-   **action-group:** ensure Action Button clicks are attributed to the right element ([#3292](https://github.com/adobe/spectrum-web-components/issues/3292)) ([ddccab7](https://github.com/adobe/spectrum-web-components/commit/ddccab766498a6da6ca29d9bbe9cebd7924e81e0))
+-   added role for href button ([5a4ad98](https://github.com/adobe/spectrum-web-components/commit/5a4ad98afa69669a8a4fb2a88d82a837c0c40c55))
+-   **color-area,color-slider:** color-area labeling, RTL support, vertical slider orientation([#3315](https://github.com/adobe/spectrum-web-components/issues/3315)) ([ca2acda](https://github.com/adobe/spectrum-web-components/commit/ca2acdafe004cb962c00ebb7f79c5b6061dc6843)), closes [#3313](https://github.com/adobe/spectrum-web-components/issues/3313)
+-   **color-loupe:** hide svg from screen readers ([#3318](https://github.com/adobe/spectrum-web-components/issues/3318)) ([01e75b7](https://github.com/adobe/spectrum-web-components/commit/01e75b7f0dbf1096976c290ad360534847781fee))
+-   **color-slider,color-wheel:** fix focused state [#3278](https://github.com/adobe/spectrum-web-components/issues/3278) ([96b83f7](https://github.com/adobe/spectrum-web-components/commit/96b83f7eb6ead1de2b30f1483478a2e5d6195349))
+-   **color-slider:** announce new value on change after keydown ([#3304](https://github.com/adobe/spectrum-web-components/issues/3304)) ([d70d0ae](https://github.com/adobe/spectrum-web-components/commit/d70d0aefdc03524192c3b8a0d6cb901cf49d37a9)), closes [#3303](https://github.com/adobe/spectrum-web-components/issues/3303)
+-   **number-field,search,textfield:** add t-shirt sizes ([fda8f96](https://github.com/adobe/spectrum-web-components/commit/fda8f96b71b1447a8281f73d885c1c33ae74cfec))
+-   **picker:** correct label application for screen readers ([8ce0cb0](https://github.com/adobe/spectrum-web-components/commit/8ce0cb0b76fcb76af34fdd3228ae268509f80ee0))
+-   **radio:** fix radio documentation usage of sp-field-label[for] and sp-radio-group[id] ([60f54fb](https://github.com/adobe/spectrum-web-components/commit/60f54fb2c5f656cc775d52637e1ef95bde5949f5))
+-   **sidenav:** express hierarchy using list and listitem ([f9019d7](https://github.com/adobe/spectrum-web-components/commit/f9019d7f5a37c81b61395d5329b251317497a685)), closes [#3348](https://github.com/adobe/spectrum-web-components/issues/3348) [#3348](https://github.com/adobe/spectrum-web-components/issues/3348)
+-   **slider:** [#3340](https://github.com/adobe/spectrum-web-components/issues/3340) fix visual regression ([88e0bda](https://github.com/adobe/spectrum-web-components/commit/88e0bda41df9f1ebb21debf97db05b0fd144deb7))
+-   **slider:** slider input aria-valuetext omits formatOptions for unit [#3340](https://github.com/adobe/spectrum-web-components/issues/3340) ([d5ff7e6](https://github.com/adobe/spectrum-web-components/commit/d5ff7e6e0196580f25941caa1a304557cb0f5088))
+-   **swatch:** mixed-value state must be conveyed to screen readers using ARIA ([#3330](https://github.com/adobe/spectrum-web-components/issues/3330)) ([7711264](https://github.com/adobe/spectrum-web-components/commit/7711264850f54794fc2fcc343a81c5ff1f64c907))
+-   **table:** include all dependencies, @lit-labs/observers was missing ([98d0370](https://github.com/adobe/spectrum-web-components/commit/98d03701b05101bae4a9e1f4d554bf0648979884))
+-   text fixes ([0121fd6](https://github.com/adobe/spectrum-web-components/commit/0121fd6e25755881f5f00c8b7cd989fc47e201d8))
+-   **textfield:** add rows attribute ([#3356](https://github.com/adobe/spectrum-web-components/issues/3356)) ([1ee1c37](https://github.com/adobe/spectrum-web-components/commit/1ee1c37f219c82fd74ca1b89941d4f59ccfd2785))
+-   **vrt-compare:** updating the readme about vrt tests ([#3380](https://github.com/adobe/spectrum-web-components/issues/3380)) ([8eb28c8](https://github.com/adobe/spectrum-web-components/commit/8eb28c866c960b2cf27930cc1eab8f96e2c057d9))
+
+### Features
+
+-   **accordion:** core token migration ([#3300](https://github.com/adobe/spectrum-web-components/issues/3300)) ([9650b71](https://github.com/adobe/spectrum-web-components/commit/9650b71dd7cf7b93c351ac7b369aaf424c82f47d))
+-   **card:** use core tokens ([9cccd26](https://github.com/adobe/spectrum-web-components/commit/9cccd26f00f688cbe1477dc7a9ce01542b179737))
+-   **tabs,top-nav:** use Core Tokens ([c6ba355](https://github.com/adobe/spectrum-web-components/commit/c6ba355c2160d1a8bda1618b8a9c28213194c7c5))
+
 ## [0.33.2](https://github.com/adobe/spectrum-web-components/compare/v0.33.1...v0.33.2) (2023-06-14)
 
 **Note:** Version bump only for package @adobe/spectrum-web-components

README.md

@@ -125,9 +125,18 @@ To create a local baseline for comparing your changes to later in the developmen
 yarn test:visual:clean # start with a clean slate
 # yarn test:visual:clean:baseline # removes only baseline images
 # yarn test:visual:clean:current # removes only images updated in the most recent test pass
-yarn test:visual vrt-light-medium-ltr # vrt-${color}-${scale}-${direction} to access all theme options
-# ...
-yarn test:visual vrt-light-medium-ltr # repeat the same as above for a clean comparison
+
+# To enable comparison, it is generally recommended to generate baselines on the main branch.
+yarn test:visual vrt-${component name} --update-visual-baseline
+eg: yarn test:visual vrt-accordion --update-visual-baseline
+
+# Running the tests on the local branch
+yarn test:visual vrt-${component name}
+eg: yarn test:visual vrt-accordion
+
+# Running the tests of light medium ltr
+yarn test:visual vrt-${component name}-single
+eg: yarn test:visual vrt-accordion-single
 ```
 
 #### Screenshot coverage

lerna.json

@@ -1,6 +1,6 @@
 {
     "packages": ["packages/*", "projects/*", "tools/*"],
-    "version": "0.33.2",
+    "version": "0.34.0",
     "granularPathspec": false,
     "npmClient": "yarn",
     "useWorkspaces": true,

linters/stylelint-header/yarn.lock

@@ -2542,6 +2542,11 @@ punycode@^2.1.0, punycode@^2.1.1:
   resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
   integrity sha1-tYsBCsQMIsVldhbI0sLALHv0eew=
 
+querystringify@^2.1.1:
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/querystringify/-/querystringify-2.2.0.tgz#3345941b4153cb9d082d8eee4cda2016a9aef7f6"
+  integrity sha512-FIqgj2EUvTa7R50u0rGsyTftzjYmv/a3hO345bZNrqabNqjtgiDMgmo4mkUjd+nzU5oF3dClKqFIPUKybUyqoQ==
+
 queue-microtask@^1.2.2:
   version "1.2.3"
   resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/queue-microtask/-/queue-microtask-1.2.3.tgz#4929228bbc724dfac43e0efb058caf7b6cfb6243"
@@ -2594,6 +2599,11 @@ require-from-string@^2.0.2:
   resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/require-from-string/-/require-from-string-2.0.2.tgz#89a7fdd938261267318eafe14f9c32e598c36909"
   integrity sha1-iaf92TgmEmcxjq/hT5wy5ZjDaQk=
 
+requires-port@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff"
+  integrity sha512-KigOCHcocU3XODJxsu8i/j8T9tzT4adHiecwORRQ0ZZFcp7ahwXuRU1m+yuO90C5ZUyGeGfocHDI14M3L3yDAQ==
+
 resolve-cwd@^3.0.0:
   version "3.0.0"
   resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/resolve-cwd/-/resolve-cwd-3.0.0.tgz#0f0075f1bb2544766cf73ba6a6e2adfebcb13f2d"
@@ -2662,19 +2672,19 @@ saxes@^5.0.1:
     xmlchars "^2.2.0"
 
 "semver@2 || 3 || 4 || 5":
-  version "5.7.1"
-  resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
-  integrity sha1-qVT5Ma66UI0we78Gnv8MAclhFvc=
+  version "5.7.2"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.2.tgz#48d55db737c3287cd4835e17fa13feace1c41ef8"
+  integrity sha512-cBznnQ9KjJqU67B52RMC65CMarK2600WFnbkcaiwWq3xy/5haFJlshgnpjovMVJ+Hff49d8GEn0b87C5pDQ10g==
 
 semver@^6.0.0, semver@^6.3.0:
-  version "6.3.0"
-  resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
-  integrity sha1-7gpkyK9ejO6mdoexM3YeG+y9HT0=
+  version "6.3.1"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4"
+  integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==
 
 semver@^7.3.2, semver@^7.3.4:
-  version "7.3.7"
-  resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/semver/-/semver-7.3.7.tgz#12c5b649afdbf9049707796e22a4028814ce523f"
-  integrity sha1-EsW2Sa/b+QSXB3luIqQCiBTOUj8=
+  version "7.5.4"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.4.tgz#483986ec4ed38e1c6c48c34894a9182dbff68a6e"
+  integrity sha512-1bCSESV6Pv+i21Hvpxp3Dx+pSD8lIPt8uVjRrxAUt/nbswYc+tK6Y2btiULjd4+fnq15PX+nqQDC7Oft7WkwcA==
   dependencies:
     lru-cache "^6.0.0"
 
@@ -2983,13 +2993,14 @@ to-regex-range@^5.0.1:
     is-number "^7.0.0"
 
 tough-cookie@^4.0.0:
-  version "4.0.0"
-  resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/tough-cookie/-/tough-cookie-4.0.0.tgz#d822234eeca882f991f0f908824ad2622ddbece4"
-  integrity sha1-2CIjTuyogvmR8PkIgkrSYi3b7OQ=
+  version "4.1.3"
+  resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-4.1.3.tgz#97b9adb0728b42280aa3d814b6b999b2ff0318bf"
+  integrity sha512-aX/y5pVRkfRnfmuX+OdbSdXvPe6ieKX/G2s7e98f4poJHnqH3281gDPm/metm6E/WRamfx7WC4HUqkWHfQHprw==
   dependencies:
     psl "^1.1.33"
     punycode "^2.1.1"
-    universalify "^0.1.2"
+    universalify "^0.2.0"
+    url-parse "^1.5.3"
 
 tr46@^2.1.0:
   version "2.1.0"
@@ -3042,10 +3053,10 @@ typedarray-to-buffer@^3.1.5:
   dependencies:
     is-typedarray "^1.0.0"
 
-universalify@^0.1.2:
-  version "0.1.2"
-  resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66"
-  integrity sha1-tkb2m+OULavOzJ1mOcgNwQXvqmY=
+universalify@^0.2.0:
+  version "0.2.0"
+  resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.2.0.tgz#6451760566fa857534745ab1dde952d1b1761be0"
+  integrity sha512-CJ1QgKmNg3CwvAv/kOFmtnEN05f0D/cn9QntgNOQlQF9dgvVTHj3t+8JPdjqawCHk7V/KA+fbUqzZ9XWhcqPUg==
 
 uri-js@^4.2.2:
   version "4.4.1"
@@ -3054,6 +3065,14 @@ uri-js@^4.2.2:
   dependencies:
     punycode "^2.1.0"
 
+url-parse@^1.5.3:
+  version "1.5.10"
+  resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.5.10.tgz#9d3c2f736c1d75dd3bd2be507dcc111f1e2ea9c1"
+  integrity sha512-WypcfiRhfeUP9vvF0j6rw0J3hrWrw6iZv3+22h6iRMJ/8z1Tj6XfLP4DsUix5MhMPnXpiHDoKyoZ/bdCkwBCiQ==
+  dependencies:
+    querystringify "^2.1.1"
+    requires-port "^1.0.0"
+
 util-deprecate@^1.0.2:
   version "1.0.2"
   resolved "https://artifactory.corp.adobe.com/artifactory/api/npm/npm-unified-experience-components-release/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"

package.json

@@ -100,7 +100,7 @@
         "@netlify/build": "^29.1.0",
         "@open-wc/dev-server-hmr": "^0.1.3",
         "@open-wc/testing": "^3.1.7",
-        "@rollup/plugin-commonjs": "^24.0.1",
+        "@rollup/plugin-commonjs": "^25.0.2",
         "@rollup/plugin-json": "^6.0.0",
         "@rollup/plugin-node-resolve": "^15.0.1",
         "@sindresorhus/slugify": "^2.1.1",
@@ -130,13 +130,13 @@
         "alex": "^10.0.0",
         "cem-plugin-module-file-extensions": "^0.0.5",
         "chalk": "^5.0.1",
-        "chromedriver": "^112.0.1",
+        "chromedriver": "^114.0.2",
         "common-tags": "^1.8.2",
         "cssnano": "^5.0.15",
         "custom-elements-manifest": "^2.0.0",
         "debounce": "^1.2.1",
         "deepmerge": "^4.2.2",
-        "esbuild": "^0.17.3",
+        "esbuild": "^0.17.19",
         "eslint": "^8.23.0",
         "eslint-config-prettier": "^8.5.0",
         "eslint-formatter-pretty": "^5.0.0",
@@ -149,6 +149,7 @@
         "fs-extra": "^10.0.0",
         "geckodriver": "4.0.3",
         "gh-pages": "^4.0.0",
+        "glob": "^10.3.0",
         "gunzip-maybe": "^1.4.2",
         "husky": "^8.0.1",
         "latest-version": "^7.0.0",
@@ -164,7 +165,7 @@
         "patch-package": "^6.4.7",
         "playwright": "1.30.0",
         "postcss": "^8.4.14",
-        "postcss-custom-properties": "^12.1.11",
+        "postcss-custom-properties": "^13.2.0",
         "postcss-focus-visible": "^7.1.0",
         "postcss-import": "^15.1.0",
         "postcss-mixins": "^9.0.4",

packages/accordion/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [0.34.0](https://github.com/adobe/spectrum-web-components/compare/v0.33.2...v0.34.0) (2023-07-11)
+
+### Features
+
+-   **accordion:** core token migration ([#3300](https://github.com/adobe/spectrum-web-components/issues/3300)) ([9650b71](https://github.com/adobe/spectrum-web-components/commit/9650b71dd7cf7b93c351ac7b369aaf424c82f47d))
+
 ## [0.33.2](https://github.com/adobe/spectrum-web-components/compare/v0.33.1...v0.33.2) (2023-06-14)
 
 **Note:** Version bump only for package @spectrum-web-components/accordion