feat(date-time-picker): add time field component (WIP) #3427

paulodetarsofm · 2023-07-10T13:03:49Z

Description

Adding the second component that will be part of the date/time picker: the time field.

The first component is the calendar.

Related issue(s)

#2626

Motivation and context

Allow the user to enter a specific time to publish a post on social media.

How has this been tested?

Test case 1
1. Go here
2. Do this
Test case 2
1. Go here
2. Do this

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Bumps [@spectrum-css/divider](https://github.com/adobe/spectrum-css/tree/HEAD/components/divider) from 2.1.3 to 2.1.7. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/divider/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/divider@2.1.7/components/divider) --- updated-dependencies: - dependency-name: "@spectrum-css/divider" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@spectrum-css/table](https://github.com/adobe/spectrum-css/tree/HEAD/components/table) from 4.0.50 to 4.0.56. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/table/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/table@4.0.56/components/table) --- updated-dependencies: - dependency-name: "@spectrum-css/table" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@open-wc/eslint-config](https://github.com/open-wc/open-wc/tree/HEAD/packages/eslint-config) from 10.0.0 to 11.0.0. - [Release notes](https://github.com/open-wc/open-wc/releases) - [Changelog](https://github.com/open-wc/open-wc/blob/master/packages/eslint-config/CHANGELOG.md) - [Commits](https://github.com/open-wc/open-wc/commits/HEAD/packages/eslint-config) --- updated-dependencies: - dependency-name: "@open-wc/eslint-config" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@spectrum-css/popover](https://github.com/adobe/spectrum-css/tree/HEAD/components/popover) from 6.0.46 to 6.0.54. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/popover/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/popover@6.0.54/components/popover) --- updated-dependencies: - dependency-name: "@spectrum-css/popover" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@spectrum-css/actionmenu](https://github.com/adobe/spectrum-css/tree/HEAD/components/actionmenu) from 4.0.31 to 4.0.39. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/actionmenu/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/actionmenu@4.0.39/components/actionmenu) --- updated-dependencies: - dependency-name: "@spectrum-css/actionmenu" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [glob](https://github.com/isaacs/node-glob) from 8.0.3 to 10.3.0. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v8.0.3...v10.3.0) --- updated-dependencies: - dependency-name: glob dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…sp-radio-group[id]

* fix(sidenav): [Bug][a11y]: sidenav should express hierarchy using list and listitem #3348 * fix(sidenav): updates per code review #3348

* feat(textfield): add rows attribute * ensure that multiline textarea with rows is not resizable * added unit tests for rows attribute * remove obsolete css style * update golden image caches

…right element (#3292)

* feat(accordion): accordion core token migration * chore(accordion): updating the storybook * chore(accordion): minor fixes * chore(accordion): updating new beta package * feat(accordion): addressing review suggestions * chore: chevron sizing approach * chore(accordion): removing ununsed code * feat(accordion): addressing review suggestions * feat(accordion): updating the default variables * feat(accordion): minor fix * feat(accordion): updating the documentation * feat(accordion): updating the storybook --------- Co-authored-by: Venkatesh Josyula <venkateshjo@adobe.com> Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>

…ng ARIA (#3330) * fix: mixed value state of swatch support aria * chore: added test to support mixed-value for aria * chore: updated readme * fix: removed aria checked from readme * fix: aria-label fix for swatch in screen reader * fix: aria-label fix for swatch in screen reader * chore: added tests * chore: updated readme and removed comments * fix: tests --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>

* chore: include custom vars in theme imports * chore(theme): add imports for express custom vars * chore: custom-lightest-vars doesnt exist so changed filename * chore: update ci hash --------- Co-authored-by: Najika Yoo <naj.halsema@gmail.com>

Bumps [postcss-custom-properties](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-custom-properties) from 12.1.11 to 13.2.0. - [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-custom-properties/CHANGELOG.md) - [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugins/postcss-custom-properties) --- updated-dependencies: - dependency-name: postcss-custom-properties dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@11ty/eleventy](https://github.com/11ty/eleventy) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/11ty/eleventy/releases) - [Changelog](https://github.com/11ty/eleventy/blob/master/docs/release-instructions.md) - [Commits](11ty/eleventy@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: "@11ty/eleventy" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.0.2 to 15.1.0. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v15.1.0/packages/node-resolve) --- updated-dependencies: - dependency-name: "@rollup/plugin-node-resolve" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…cal slider orientation(#3315) * fix(color-area,color-slider): color-area labeling, RTL support, vertical slider orientation #3313 * ci: update golden images cache

Bumps [@spectrum-css/statuslight](https://github.com/adobe/spectrum-css/tree/HEAD/components/statuslight) from 6.0.35 to 6.0.38. - [Release notes](https://github.com/adobe/spectrum-css/releases) - [Changelog](https://github.com/adobe/spectrum-css/blob/main/components/statuslight/CHANGELOG.md) - [Commits](https://github.com/adobe/spectrum-css/commits/@spectrum-css/statuslight@6.0.38/components/statuslight) --- updated-dependencies: - dependency-name: "@spectrum-css/statuslight" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@open-wc/eslint-config](https://github.com/open-wc/open-wc/tree/HEAD/packages/eslint-config) from 11.0.0 to 12.0.0. - [Release notes](https://github.com/open-wc/open-wc/releases) - [Changelog](https://github.com/open-wc/open-wc/blob/master/packages/eslint-config/CHANGELOG.md) - [Commits](https://github.com/open-wc/open-wc/commits/HEAD/packages/eslint-config) --- updated-dependencies: - dependency-name: "@open-wc/eslint-config" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [postcss-loader](https://github.com/webpack-contrib/postcss-loader) from 6.2.1 to 7.3.3. - [Release notes](https://github.com/webpack-contrib/postcss-loader/releases) - [Changelog](https://github.com/webpack-contrib/postcss-loader/blob/master/CHANGELOG.md) - [Commits](webpack/postcss-loader@v6.2.1...v7.3.3) --- updated-dependencies: - dependency-name: postcss-loader dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@web/dev-server](https://github.com/modernweb-dev/web/tree/HEAD/packages/dev-server) from 0.2.1 to 0.2.5. - [Release notes](https://github.com/modernweb-dev/web/releases) - [Changelog](https://github.com/modernweb-dev/web/blob/master/packages/dev-server/CHANGELOG.md) - [Commits](https://github.com/modernweb-dev/web/commits/@web/dev-server@0.2.5/packages/dev-server) --- updated-dependencies: - dependency-name: "@web/dev-server" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>

…ield

paulodetarsofm · 2023-07-18T14:19:42Z

This component will be converted into an "abstract component", which will be used as a base to create the time field and also the date/time picker

Najika Yoo and others added 30 commits June 20, 2023 12:33

chore: update chromedriver

305eb6f

chore: add yarn lock

f69086f

chore: pull in new changes from css update

08da53a

chore: accept non-breaking Spectrum CSS updates

fcfcdad

ci: update golden images cache

148159f

fix: added role for href button

5a4ad98

chore: documentation of href button

a20fb41

fix: text fixes

0121fd6

fix(color-slider,color-wheel): fix focused state #3278

96b83f7

ci: update golden images cache

a17290b

docs: correct typoes and URLs

843037b

fix(radio): fix radio documentation usage of sp-field-label[for] and …

60f54fb

…sp-radio-group[id]

fix(sidenav): express hierarchy using list and listitem

f9019d7

* fix(sidenav): [Bug][a11y]: sidenav should express hierarchy using list and listitem #3348 * fix(sidenav): updates per code review #3348

fix(textfield): add rows attribute (#3356)

1ee1c37

* feat(textfield): add rows attribute * ensure that multiline textarea with rows is not resizable * added unit tests for rows attribute * remove obsolete css style * update golden image caches

feat: add new time-field component

d50807c

docs(tooltip): document self-managed API

217db8e

fix(color-loupe): hide svg from screen readers (#3318)

01e75b7

fix(action-group): ensure Action Button clicks are attributed to the …

ddccab7

…right element (#3292)

beeduul and others added 27 commits July 11, 2023 11:32

docs: spelling fix in swatch-group docs

d244a63

fix(color-area,color-slider): color-area labeling, RTL support, verti…

ca2acda

…cal slider orientation(#3315) * fix(color-area,color-slider): color-area labeling, RTL support, vertical slider orientation #3313 * ci: update golden images cache

feat(tabs,top-nav): use Core Tokens

c6ba355

ci: update golden images cache

98c3241

chore: release new versions #publish

f9b3294

fix(color-wheel): reorient reactively to "dir" changes (#3319)

6a9dcec

docs: massaged Popover docs, wording, examples

96270ca

docs: fixed typos in documentation readme

caf989d

fix(time-field): handling typed values

a430126

fix(time-field): handling cleared values

02aae3a

fix: disable Storybook shortcuts for contenteditable

f206598

refactor(time-field): add to-do list

d2800a9

build: correct webpack examples

fc7a4f2

test: use long tooltip content in VRTs

2c3c088

ci: update golden images cache

2e0cc39

chore: take latest non-breaking Spectrum CSS dependencies

3a87ee0

ci: update golden images cache

f8ad3da

fix(meter): added role meter progressbar in meter component (#3459)

d2eccef

Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>

docs: updated swatch mixed documentations (#3455)

cce9d4c

Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>

fix(textfield): update focus state when [multiline][quiet] (#3452)

a7f563a

Merge remote-tracking branch 'origin/main' into paulodetarsofm/time-f…

b9a9007

…ield

refactor(time-field): bump time field dependencies

cc5e59a

refactor(time-field): fix story name

321b1a1

paulodetarsofm closed this Jul 18, 2023

paulodetarsofm deleted the paulodetarsofm/time-field branch July 24, 2023 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(date-time-picker): add time field component (WIP) #3427

feat(date-time-picker): add time field component (WIP) #3427

Uh oh!

paulodetarsofm commented Jul 10, 2023

Uh oh!

paulodetarsofm commented Jul 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

feat(date-time-picker): add time field component (WIP) #3427

feat(date-time-picker): add time field component (WIP) #3427

Uh oh!

Conversation

paulodetarsofm commented Jul 10, 2023

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

Uh oh!

paulodetarsofm commented Jul 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants