Skip to content

Conversation

@castastrophe
Copy link
Contributor

Description

The branch configurations require approval for PRs from 2 "code owners". Ideally, for CSS-focused updates, I think we can include the CSS maintainers group in that category.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025

⚠️ No Changeset found

Latest commit: c2caace

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@castastrophe castastrophe self-assigned this Jun 2, 2025
@castastrophe castastrophe added Component: Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira Administrative Spectrum CSS Status: Ready for review PR ready for review or re-review. labels Jun 2, 2025
@castastrophe castastrophe marked this pull request as ready for review June 2, 2025 21:11
@castastrophe castastrophe requested a review from a team as a code owner June 2, 2025 21:11
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the castastrophe/chore-update-codeowners branch from 044d3da to 3d510f9 Compare June 2, 2025 21:14
@castastrophe castastrophe requested review from jnjosh and pfulton June 10, 2025 22:07
@castastrophe castastrophe force-pushed the castastrophe/chore-update-codeowners branch 2 times, most recently from 515cc26 to accab8b Compare June 10, 2025 22:11
@castastrophe castastrophe force-pushed the castastrophe/chore-update-codeowners branch from accab8b to c2caace Compare June 11, 2025 16:53
@pfulton
Copy link
Collaborator

pfulton commented Jun 11, 2025

@castastrophe I initially approved this, but @jnjosh and I adjusted the team assignments so that everyone who is a full-time Adobe employee on SWC and CSS are now part of the @adobe/swc-maintainers "team". So: leaving this file as it is today on main should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira Spectrum CSS Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants