-
Notifications
You must be signed in to change notification settings - Fork 356
#2060 Add fieldgroups and examples supporting Paid Media #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ejsuncy
wants to merge
16
commits into
adobe:master
Choose a base branch
from
ejsuncy:master-2060-support-paid-media-fieldgroups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#2060 Add fieldgroups and examples supporting Paid Media #2063
ejsuncy
wants to merge
16
commits into
adobe:master
from
ejsuncy:master-2060-support-paid-media-fieldgroups
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2025
68ecc4b to
61b5721
Compare
bf25923 to
fe7439a
Compare
596fa8e to
a63f4c5
Compare
…umber types to /xdm/data/measure refs" This reverts commit b5a178b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2060 will involve multiple PRs to keep the review effort manageable.
This stacked PR should not be merged before PR #2061 and should be rebased after that one is merged.
This PR adds the fieldgroups that build upon the datatypes added in #2061. These new fieldgroups capture Paid Media domain heirarchy knowledge across ad networks (meta, linkedIn, google ads, etc) such as:
It also captures performance metrics concepts, which can be reused at the various hierarchy levels mentioned above. For example, clicks/impressions performance metrics might apply at the Asset level, Ad level, Ad Group level, or Campaign level.
This PR also adds a validation script ("npm run validate") to ensure example files actually adhere to their associated schemas, and that schema "$id" references to other remote schemas actually refer to either: