AN-441822 Fix paid media examples to conform to schema definitions#2116
Merged
waykar-prashant merged 7 commits intoadobe:masterfrom Mar 30, 2026
Merged
Conversation
…obe#2115 Rewrite 27 paid media example files to use only fields, types, and enum values that exist in their corresponding schema definitions. Fieldgroup examples (9 files): - Remove xdm:additionalDetails from 6 fieldgroups that don't define it - Flatten wrapper objects in conversion-metrics and extended-metrics - Fix xdm:description namespace prefix in experience-details carousel - Fix lead form fields in asset-details to match schema Schema-level examples (18 files): - Rewrite ad/adgroup/asset/campaign/experience lookup examples with correct field names and structures per their fieldgroup schemas - Fix summary-metrics: rename coreMetrics to metrics, flatten dimensional breakdowns, correct quality metrics field names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@waykar-prashant anything else to do for this PR? |
waykar-prashant
approved these changes
Mar 30, 2026
Collaborator
waykar-prashant
left a comment
waykar-prashant
left a comment
There was a problem hiding this comment.
These are all examples. LGTM
… cases around challenges and rewards. Also fix tier upgradeDate to be of type date-time. (adobe#2122)
Change lowest_cost_without_cap to lowest_cost in Meta campaign example to match the bidStrategy enum added in PR adobe#2112. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2115
xdm:additionalDetailsfrom fieldgroups that don't define it, flattens wrapper objects in conversion/extended metrics, fixes namespace prefix in experience-details, corrects lead form fields in asset-detailsAll examples validated against schemas with zero discrepancies.
npm testpasses (2366 passing).🤖 Generated with Claude Code