MWPW-191644: Include "firefly-howto" in iconsExclusionBlocks#963
Merged
nkthakur48 merged 2 commits intostagefrom Apr 6, 2026
Merged
MWPW-191644: Include "firefly-howto" in iconsExclusionBlocks#963nkthakur48 merged 2 commits intostagefrom
nkthakur48 merged 2 commits intostagefrom
Conversation
nkthakur48
requested review from
Ruchika4,
drashti1712,
hkhatana26,
hkuraware and
suhjainadobe
|
hkuraware
approved these changes
Apr 6, 2026
|
Skipped merging 963: MWPW-191644: Include "firefly-howto" in iconsExclusionBlocks due to failing checks |
hkhatana26
approved these changes
Apr 6, 2026
Collaborator
|
Validation done on the pr console error is not seen |
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Apr 7, 2026
Based on test results here - adobecom#963 merging this PR.
nkthakur48
added a commit
that referenced
this pull request
Apr 13, 2026
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Apr 15, 2026
* MWPW-191602: Disable geo-routing modal for French sites #22 MWPW-191602: Disable geo-routing modal for French sites * MWPW-191644: Include "firefly-howto" in iconsExclusionBlocks (#26) Based on test results here - adobecom#963 merging this PR. * MWPW-190523, MWPW-187015: Fixed A11y issue and restructure the block (#28) * MWPW-192019: Avoid applying grid styles to .aside.promobar (#30) * Update 404.html (#31) * MWPW-191633: Adds to setLibs array to allow the use of milolibs= on stage (#24) * Adds to setLibs array to allow the use of milolibs= on stage * Ensures that stage.a.com pages point to stage milo as they are expected to * Renaming to localhost again --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * Revert "MWPW-191633: Adds to setLibs array to allow the use of milolibs= on s…" (#33) This reverts commit 2c94a7c. * revert 404 update (#32) * MWPW-189460-width changes for editorial card for tablet (adobecom#936) * width changes for editorial card for tablet * fixed review comments * removed extra padding --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * MWPW-189449: reducing the padding below the carosuel for mobile (adobecom#958) Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-191475]: Unit Test cases [FF]- How to block (adobecom#969) --------- Co-authored-by: Sunil Kamat <107644736+sukamat@users.noreply.github.com> Co-authored-by: Himani Kuraware <hkuraware@adobe.com> Co-authored-by: Jason Slavin <slavin.jhs@gmail.com> Co-authored-by: Harshad Khatana <hkhatana@adobe.com> Co-authored-by: Suhani Jain <110388864+suhjainadobe@users.noreply.github.com> Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-191644
Test URLs:
Dev validation
