Merged
Conversation
* width changes for editorial card for tablet * fixed review comments * removed extra padding --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
… issue. (#965) * Fixed a11y issue in prm-yt * Removed aria-expanded from card * used lowercase tabindex in createCloseButton via createTag * handled loading state of card
Author
|
Testing can start @adobecom/creative-cloud-sot |
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
…tage (#962) * Adds to setLibs array to allow the use of milolibs= on stage * Ensures that stage.a.com pages point to stage milo as they are expected to * Renaming to localhost again --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 88.39% 88.77% +0.37%
==========================================
Files 42 41 -1
Lines 9146 9192 +46
==========================================
+ Hits 8085 8160 +75
+ Misses 1061 1032 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nkthakur48
approved these changes
Apr 13, 2026
Collaborator
|
CMR : CHG003930761 |
hkuraware
approved these changes
Apr 13, 2026
Collaborator
|
Validation on the above pr is done via stage--cc--adobecom.aem.page , validation would be done once change is in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creative cloud: