[MWPW-193670] Wave2.1 - Image to video changes#751
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
arugupta1992
changed the title
| getVerbFromDom() { | ||
| const verbEl = this.unityEl?.querySelector('[class*="icon-operation-"]'); | ||
| if (verbEl) { | ||
| const verbClass = Array.from(verbEl.classList).find((cls) => cls.startsWith('icon-operation-')); | ||
| const fromDom = verbClass?.slice('icon-operation-'.length); | ||
| if (fromDom) return fromDom; | ||
| } | ||
| return this.workflowCfg?.enabledFeatures?.[0]; | ||
| } |
There was a problem hiding this comment.
I believe it was previously discussed that a better approach would be to extract verb from the block class token instead. What do you think?
There was a problem hiding this comment.
We can discuss this further, but from an approach standpoint, I think both options are reasonable. My main concern is maintaining consistency across waves. At the moment, we already have two different class naming conventions:
-
- Wave 1: icon-verb-*
-
- Wave 1.5.1: icon-operation-*
If we switch approaches for this workflow, we’ll end up maintaining three different patterns for extracting the verb name since I don’t think it would be practical to request changes in pages from previous waves.
My concern is that, over time, this becomes harder to reason about and remember, especially when revisiting the codebase later. So IMO, we should continue with the current approach until we have an opportunity to make this consistent across waves. Wdyt?
arugupta1992
changed the title
Testing Notes: 1. Regress all the upload workflow acros products 2. Test the limits for each product Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/upscale-video?unitylibs=stage - After: https://main--da-cc--adobecom.aem.page/drafts/arugupta/image-to-video/doodlebug/upscale-video?unitylibs=upscaleVid --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
| letter-spacing: -1.92px; | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This looks like a git error. Nothing to revert here.
| } | ||
|
|
||
| readFeatureFlags() { | ||
| this.showAspectRatio = !!this.el.querySelector('[class*="icon-show-aspect-ratio"]'); |
There was a problem hiding this comment.
should we also check for the value as true or not for these keys?
There was a problem hiding this comment.
Not sure, can you elaborate the intention around that? By default we are taking it as false. If it needs to be added then it should be authored.
| return rightSection; | ||
| } | ||
|
|
||
| buildDropZone() { |
There was a problem hiding this comment.
please check with Jordan once if the complete marquee should act as a dropzone for drag and drop, as this was a requirement in earlier upload-marquee workflows.
| }); | ||
| } | ||
|
|
||
| async initWidget() { |
There was a problem hiding this comment.
please check the left side of the upload marquee is taking more than 50% of the total width.
There was a problem hiding this comment.
That's as per design
| this.actionMap = actionMap; | ||
| this.errorToastEl = null; | ||
| this.transitionScreen = null; | ||
| this.LOADER_LIMIT = 95; |
There was a problem hiding this comment.
That's the max cap for progress bar avoid going beyond 100 without finishing the upload tasks.
| } | ||
| if (this.limits.maxDuration && duration > this.limits.maxDuration) { | ||
| this.handleClientUploadError('.icon-error-videoduration', 'error-videoduration', 'Video is too long'); | ||
| throw new Error('Video is too long'); |
There was a problem hiding this comment.
do these need to be localized?
There was a problem hiding this comment.
This is for analytics.
#760) … drop <!-- Before submitting, please review all open PRs. --> * Add your * Specific * Features or fixes Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://<branch>--unity--adobecom.aem.page/?martech=off Co-authored-by: vipulg <vipulg@adobe.com>
|
Validation completed in the branch URL. Test results are in the task :MWPW-193897 |
* #751 * #754 * #762 * #746 * #763 * #769 * #768 * #770 **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/products/firefly/features/ai-video-generator?unitylibs=main - After: https://main--da-cc--adobecom.aem.page/products/firefly/features/ai-video-generator?unitylibs=release-051226 - Before: https://main--da-dc--adobecom.aem.live/drafts/maagrawal/study-space/mindmap-maker-test?unitylibs=main - After: https://main--da-dc--adobecom.aem.page/drafts/maagrawal/study-space/mindmap-maker-test?unitylibs=release-051226
4 participants
Testing Notes:
Resolves: MWPW-193670
Test URLs: