Skip to content

fix: mismatch catch err variable used#77

Merged
thetutlage merged 3 commits intoadonisjs:10.xfrom
davisthedev:10.x
Feb 23, 2026
Merged

fix: mismatch catch err variable used#77
thetutlage merged 3 commits intoadonisjs:10.xfrom
davisthedev:10.x

Conversation

@davisthedev
Copy link

🔗 Linked issue

76

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The catch block was using error (from validateProcessedBytes) instead of
err (the caught exception), causing undefined to be emitted when
reportProgress throws, which crashes the error handler.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Hey @davisthedev

Seems like there are linting and formatting errors. Can you please fix them?

@davisthedev
Copy link
Author

@thetutlage my apologies, all fixed.

@thetutlage thetutlage merged commit afa988b into adonisjs:10.x Feb 23, 2026
8 checks passed
@thetutlage
Copy link
Member

Thanks for the PR 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants