Etag option ignored

[mhingston]

Brief Description

ETag header is being set when explicitly set to false in config.

Sample Code

Set etag: false in config/app.js

Screenshots (if any)

[thetutlage]

I believe this is for static assets only. Can u share the full config file

[mhingston]

Hi @thetutlage, it seems to be set on all routes? I have a repro here.

When I request /test which returns a JSON response the ETag is still present.

[thetutlage]

If u look at the config file, the etag setting is inside the static section. Which means this setting only applies to the static resources served from the public dir

https://github.com/mhingston/adonis-fullstack-app/blob/586cd7fbc88de6637a97fded68aa3f1a7ffcf21d/config/app.js#L84

[mhingston]

@thetutlage sure hear what you are saying that the setting is for static assets only, but as the ETag header is also being set on responses which aren't serving static assets, how do I switch the Etag header off?

[thetutlage]

Yeah there is no way to ignore Etag when making response from routes. I will add an option for it too

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.