fix(Response): correctly send the response when file doesn't exist while streaming it #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
It seems that the correct type for the
errorvariable created inside a stream callback isNodeJS.ErrnoException.Therefor, this type doesn't have any
statusproperty, this means we cannot use it to send back the status.Types of changes
I have corrected the type in the callback and added a test to ensure no regression and that the change fixed an actual bug (before, the status was always 500).
Checklist