Skip to content

fix: allow body in 201 created responses #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged

fix: allow body in 201 created responses #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adonis-typings/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ declare module '@ioc:Adonis/Core/Response' {
continue(): void
switchingProtocols(): void
ok(body: any, generateEtag?: boolean): void
created(): void
created(body?: any, generateEtag?: boolean): void
accepted(body: any, generateEtag?: boolean): void
nonAuthoritativeInformation(body: any, generateEtag?: boolean): void
noContent(): void
Expand Down
4 changes: 2 additions & 2 deletions src/Response/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,9 +926,9 @@ export class Response extends Macroable implements ResponseContract {
return this.send(body, generateEtag)
}

public created(): void {
public created(body?: any, generateEtag?: boolean): void {
this.status(201)
return this.send(null, false)
return this.send(body, generateEtag)
}

public accepted(body: any, generateEtag?: boolean): void {
Expand Down