Skip to content

fix: improve typings for object used as dictionaries #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thetutlage merged 1 commit into from
Feb 21, 2021
Merged

fix: improve typings for object used as dictionaries #38

thetutlage merged 1 commit into from
Feb 21, 2021

Conversation

@targos
Copy link
Member

@targos targos commented Feb 21, 2021

Replace any and object with Record<string, any>.

@targos
fix: improve typings for object used as dictionaries
b6b28c6 
Replace `any` and `object` with `Record<string, any>`.
@thetutlage thetutlage merged commit fa2af33 into adonisjs:develop Feb 21, 2021
@thetutlage
Copy link
Member

thetutlage commented Feb 21, 2021

Thanks 👍

@thetutlage thetutlage added the Type: Enhancement Improving an existing feature label Feb 21, 2021
@thetutlage thetutlage self-requested a review February 21, 2021 13:45
@targos targos deleted the record branch February 21, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetutlage thetutlage Awaiting requested review from thetutlage

Assignees

@targos targos

Labels

Type: Enhancement Improving an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@targos @thetutlage