Allow custom timestamp configuration#69
Merged
thetutlage merged 1 commit intoadonisjs:6.xfrom Feb 19, 2025
Merged
Conversation
Member
|
Can you please add a test on how this option will be used and what will be output will look like? |
Author
|
Added tests along with a type fix |
|
Hope you can merge it! |
Member
|
Thanks @ignatevdev 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Currently only default presets for pino's timestamp option are allowed, however, this denies the ability to make a custom timestamp format or change the key of the timestamp field in log's json. This seems either like a bug or a missed feature.
I think a discussion for this is redundant as this is a very light change.