Skip to content

Add @japa/api-client 2.x and 3.x as peerDependency#43

Merged
thetutlage merged 1 commit into
adonisjs:developfrom
marcuspoehls:update-japa-apiclient-peerdependency
Jan 29, 2025
Merged

Add @japa/api-client 2.x and 3.x as peerDependency#43
thetutlage merged 1 commit into
adonisjs:developfrom
marcuspoehls:update-japa-apiclient-peerdependency

Conversation

@marcuspoehls
Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Dependency Update

📚 Description

Add @japa/api-client version 3.x as a peer dependency. This may raise the question if the @japa/api-client should be listed in peer dependencies because it requires someone to add any new major version when released. I’m not familiar with peer dependencies in modern npm versions. Maybe it’s enough to have @japa/api-client as a dev dependency.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit 9c2ba2d into adonisjs:develop Jan 29, 2025
@thetutlage
Copy link
Copy Markdown
Member

Thanks 👍

@marcuspoehls marcuspoehls deleted the update-japa-apiclient-peerdependency branch January 29, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants