fix(blocking): wake producers waiting on capacity after Reset#49
Merged
adrianbrad merged 2 commits intomainfrom Apr 21, 2026
Merged
fix(blocking): wake producers waiting on capacity after Reset#49adrianbrad merged 2 commits intomainfrom
adrianbrad merged 2 commits intomainfrom
Conversation
Asserts that OfferWait returns after Reset frees capacity. Fails on current main because Reset only broadcasts notEmptyCond, leaving producers stuck on notFullCond.Wait(). Refs #39
Reset can free capacity slots when it restores the initial (smaller) element set. Without broadcasting notFullCond, any goroutine blocked in OfferWait stays stuck until another consumer runs. Fixes #39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 442 443 +1
=========================================
+ Hits 442 443 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notFullCond, goroutines inOfferWaitstay stuck.Fixes #39
Test plan
go test -race -shuffle=on .