V37 Gate 4: Conversation Writing Workspace#114
Conversation
Add the package-owned ConversationWritingWorkspace contract, generated source-safe artifact, generator, checker, and protocol tests. Wire the fullscreen route-local writing workspace into Conversations with save, restore, summarize, handoff, source-safe redaction, keyboard behavior, responsive styling, and UI tests. Update V37 specs, roadmap, package docs, README, package scripts, Jest discovery, and gate/canon workflows for Gate 4 closure.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1a1a81005
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| output = redact(output, /\bsk-[A-Za-z0-9_-]{16,}\b/gu, '[redacted-provider-token]'); | ||
| output = redact(output, new RegExp(`\\b${['sb', 'secret'].join('_')}__[A-Za-z0-9_-]+\\b`, 'gu'), '[redacted-service-token]'); | ||
| output = redact(output, /\beyJ[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\b/gu, '[redacted-jwt]'); | ||
| output = redact(output, /\b(?:password|secret|token|private_key)\s*[:=]\s*\S+/giu, '[redacted-secret-field]'); |
There was a problem hiding this comment.
The redaction pipeline only catches fenced blocks, private keys, sk-*, sb_secret__*, JWT-shaped strings, or key/value pairs like token=...; a standalone credential (for example a pasted ghp_.../VERCEL_... token line) is not matched and will be emitted in sourceSafePreview and message. That violates the workspace contract that provider tokens and secret values must not cross the stream boundary.
Useful? React with 👍 / 👎.
| useEffect(() => { | ||
| setSummary(null); | ||
| setStatus(`${activeMode.label} workspace ready.`); | ||
| }, [activeMode.label, modeId]); |
There was a problem hiding this comment.
Switching tabs updates modeId and status but keeps the previous mode’s draft text in memory, so users can accidentally summarize/handoff or save Read Request content while the UI indicates a different mode (e.g., Need Feedback). Because storage keys are mode-specific, this also risks writing the wrong content under another mode key unless the user manually restores first.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation