Make mach6 review assessments enforce issue and plan scope#397
Conversation
Implementation PlanProblem analysismach6 currently treats factual validity as sufficient for a genuine finding. Because every genuine finding enters the fix action plan, technically valid but irrelevant observations can silently become new PR requirements across repeated automated review cycles. The corrected contract has two independent gates:
A factually valid finding can pass the first gate and fail the second; it should then normally be deferred, not marked genuine. Authoritative scope comes from the original linked issue and acceptance criteria, the latest explicit The human-approved scope has also been expanded for Formal mach6 review is also an accountability checkpoint, not an agent-owned continuation step. Implementation must be committed, pushed, and recorded before formal review so work cannot be lost or repeatedly rewritten by unsupervised review/fix cycles. The user explicitly triggers each Prior art supports these boundaries:
Deliverables
Acceptance criteria
Files to modify
Testing approach
Risks and open questions
Plan created by mach6 |
Vitest coverage
|
Progress UpdateImplemented the approved mach6 workflow changes:
Validation passed: build, workspace-link verification, Biome, 47 targeted prompt-contract tests, and the full deterministic test suite with live API tests skipped. Commit hooks also passed 4,948 tests. Commit: Progress tracked by mach6 |
Code ReviewCriticalNone. ImportantNone. Suggestions
Strengths
Agents run: code-reviewer, test-reviewer, completeness-checker, simplifier Reviewed by mach6 |
Review AssessmentClassifications
Action Plan
Assessment by mach6 |
Progress UpdateAddressed genuine review findings 1–5:
Validation passed: Biome, 47 targeted prompt-contract tests, build, workspace-link verification, the full deterministic suite with live API tests skipped, Commit: Progress tracked by mach6 |
Code ReviewCriticalNone. Important
Suggestions
Strengths
Agents run: code-reviewer, test-reviewer, completeness-checker, simplifier Reviewed by mach6 |
Review AssessmentClassifications
Action Plan
Assessment by mach6 |
Progress UpdateAddressed genuine review findings 1–4:
Validation passed: Biome, 47 targeted prompt-contract tests, build, workspace-link verification, the full test suite with 5,026 passing tests, Commit: Progress tracked by mach6 |
Closes #395
Make mach6 review assessment scope-aware, and clarify that the parent model owns implementation reasoning while feature-dev delegation is an optional context-preservation tool requiring detailed task instructions.
Implementation plan posted as a comment below.