Skip to content

v2.58.1

Choose a tag to compare

View all tags
@aebrer aebrer released this 18 Aug 12:16
· 26 commits to master since this release
v2.58.1
372986c
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Dashboard file upload and download fixes

Two dashboard bugs: JSON file uploads silently committed as 0-byte files, and downloads of files stored under dot-prefixed directories — where every dashboard upload lives — failed with 404.

What changed

  • Byte-exact JSON uploads. /api/files/upload now skips the global JSON body parser in a way co-extensive with Express's route matching (case variants and trailing slashes included), so the raw request stream pipes through untouched — JSON file uploads store the full original bytes instead of a 0-byte file.
  • Dot-prefixed downloads. The download route now passes dotfiles: "allow", so files under dot-prefixed directories download correctly with the right Content-Disposition.
  • Regression coverage. Byte-exact upload tests (exact, case-variant, and trailing-slash paths, asserting on-disk content) plus a dot-directory download regression test.

Implemented in PR 473.

Assets 2
Loading