Fix manual branching - #14
Merged
Merged
Conversation
There is something off here, it appears that all metadata is defined on the parent (expect class level meta).
There is no need to walk through the target's inheritance - simply return existing repository or undefined if none exists.
This should ensure consistent behaviour, rather than relying on previous implementation. Also added several tests for this alone.
That didn't work as expected.
Now supports the inherit argument
We no longer care about the Key / path - only if the target is or isn't a constructor.
This simplifies the decorator a lot. The flush logic didn't work as intended and made the logic very complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes the "manual branching" logic in the
@meta()decorator. The logic has been simplified such that the "flush" and "discover" parts have been entirely removed. They are no longer needed - they caused to many issues.In addition,
context.metadatais no longer used, because it has proven to be unreliable. A WeakMap is now used instead.