feat: fakes derive create/edit/delete write responses#70
Merged
Conversation
Seed posts/comments gain a mutable `deleted` flag; the fakes derive createPost/createComment/editPost/editComment/deletePost/deleteComment — mutating the seed store (new entities appear in lists, edits change content, deletes set the flag) and returning the updated view. Comments created with parent_id nest via path. Auth-gated. Consumers can drop hand-built create/edit/delete wire responses and assert the rendered result through the derived fake. Provider-matrix test covers the full create→edit→delete cycle for posts and comments on both providers; also folds in the comment like/save coverage from #69.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 3 #6 — the highest-value follow-up: derived write responses unblock the most pinned Voyager specs (composing's reply-renders, edit-updates-thread, delete-removes, create-navigates).
Seed posts/comments gain a mutable
deletedflag. The fakes derivecreatePost/createComment/editPost/editComment/deletePost/deleteComment: they mutate the seed store (new entities show up ingetPosts/getComments, edits change content, deletes set the flag) and return the updated view. Comments created withparent_idnest via path. Auth-gated; both providers (v1 usesbody→content and DELETE verbs; PieFed usesbody/titleand POST/deleteroutes).Provider-matrix test drives the full create→edit→delete cycle for posts and comments through a real client on both lemmyv1 and piefed. Also folds in the comment like/save end-to-end coverage that was reviewed in #69 but merged before it landed.
438 tests, typecheck, lint, build clean.