fix(logbook): stop the keyboard title-casing a flight's name and launch - #220
Merged
Conversation
autocapitalize="words" made iOS capitalize every word a pilot typed, so "south field, second lap" came out "South Field, Second Lap". Names and launches are prose, not titles: sentences capitalizes the first letter and leaves the rest to the pilot. Both copies of the fields change: FlightFields (detail page + the sheet a landing raises) and the desktop FlightSeat, which duplicates them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Name and Launch fields carried
autocapitalize="words", so iOScapitalized every word as the pilot typed: "south field, second lap"
came out "South Field, Second Lap". Those fields are prose, not titles.
Now
sentences(capitalize the first letter, leave the rest alone).Notes was already
sentences.Two copies of the same form had to change:
FlightFields(detail page +the sheet a landing raises) and the desktop
FlightSeat, whichduplicates the fields rather than importing them. Unifying them is a
separate cleanup.
Test
Gates green locally: tsc, eslint --max-warnings 0, format:check,
check:css, vitest (456), playwright (100 passed;
first-paint.specneeds a
pnpm buildfirst in a fresh worktree, green after).Attribute-only change; the effect is the iOS keyboard's shift state, so
the real check is on device: type a lowercase two-word launch and see it
stay lowercase.