Gate admissions on notification acknowledgement - #190
Draft
ael-dev3 wants to merge 4 commits into
Draft
Conversation
ael-dev3
marked this pull request as ready for review
August 4, 2026 03:45
ael-dev3
marked this pull request as draft
August 4, 2026 14:34
Owner
Author
|
Blocked by the single-notification invariant in #192. This branch currently permits post-admission/reissue generations (up to two reissues), which can produce more than one user-visible alert for one admission. Before this PR can return to review, rebase onto main and remove admitted-epoch delivery, every reissue surface, and any transport retargeting; retain only the exact pending-request generation, stable request ID, one FID-bound target, and monotonic terminal receipt. No code from this PR is approved for merge in its current form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/v2/access/admission-grant-contextWorker-first route and revalidates the exact pending request tuple with request-CAS immediately before admissionREQUEST SENTcopy and unlocks only after an explicit authoritativenot-requestedcheckWhy
Provider
successfulTokensproves handoff to Farcaster's notification service, not display, reading, or a click. The owner canary ultimately observed a real alert from the legacy already-admitted reconciliation path, proving transport while also confirming that transport success and admission ordering are distinct concerns. This change binds future admission to the exact alert launch plus fresh same-FID authentication.User impact
A disabled player sees
SUBMITTING REQUESTuntil SpacetimeDB confirmsREQUEST RECEIVED. Admission remains unchanged until the exact notification is opened in the verified Farcaster account. The alert now reads Welcome to the Hegemony Empire and contains no realm or world identifier.Validation
22a9efe53568125ff7eabb76f8906dc9831351a27625d737c81a07559361e3f9Production evidence and boundary
The owner reported the real Farcaster alert visible. Protected token-free live diagnostics classified the retained legacy generation as
admitted/already-sentafter six attempts with zero authority-verification failures. That evidence proves transport, not notification-before-admission ordering.Publish or prove the reviewed additive module first with data deletion disabled, deploy the matching bridge while preserving the live attested configuration, then allow the matching frontend deployment. The technical GitHub release is intentionally not a new game version. No production mutation is included in this pull request.