Handling a Message, with code examples from showcase apps#43
Conversation
josemigallas
changed the title
|
|
||
|
|
||
| [role="secondary"] | ||
| .iOS |
There was a problem hiding this comment.
@jhellar could you evaluate if this is correct? I could use some help here.
There was a problem hiding this comment.
I think that you first need to handle remote notification with https://github.com/aerogear/ios-showcase-template/blob/master/ios-showcase-template/AppDelegate.swift#L116. NotificationCenter is not part of AGSPush. It can be used to post the notification (https://github.com/aerogear/ios-showcase-template/blob/master/ios-showcase-template/push/PushHelper.swift#L18-L20) to a View so that it can be rendered. @wtrocki can you please confirm?
There was a problem hiding this comment.
I do not think that we should document parts that are not related to our SDK. Our SDK is not made to handle push notifications or anything related to push. The only purpose of the SDK is to:
Register application token to UPS server and in my opinion only this should be documented as rest is just classical apple story for push which changes so often and depends on os versions.
Same will apply to Android.
There was a problem hiding this comment.
I agree with @wtrocki that this is too big to take on, and we should skip it..
However, I disagree with the general point. It's ok to document any steps that user needs to perform in order to be successful with mobile services regardless of software origin... provided that documentation task is reasonable (and in this case, I don't think it is)
There was a problem hiding this comment.
@finp Yeah, main problem here is that this code will outdate faster than yoghurt in the fridge and people will actually get better experience if we point them to:
https://developer.apple.com/notifications/
| } | ||
| }); | ||
|
|
||
| pushObject.on("notification") |
There was a problem hiding this comment.
This is specific to ionic extension. Worth to mention that.
|
OK I updated it. I am in favor of not describing parts that are out of our SDK, it's too volatile and actually up to each particular user. |
jhellar
left a comment
jhellar
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM.
| **** | ||
|
|
||
| The {SDK} for JavaScript does not provide a way to handle incoming messages. We recommend using the link:https://ionicframework.com/docs/native/push[Ionic Push plugin]. | ||
| [source,javascript] |
There was a problem hiding this comment.
I think that this line can be removed.
65adad8 to
cd2e2ff
Compare
4 participants
Motivation: https://issues.jboss.org/browse/AEROGEAR-3007
There are many problems with tagging the code in showcase examples.
//.