Fix NyxID service access review return routing - #3579
Merged
AbigailDeng merged 2 commits intoSep 3, 2026
Merged
Conversation
AbigailDeng
merged commit Sep 3, 2026
04f57d3
into
feat/2026-08-04_workflow-activity-vnext
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workflow Activity vNext supplied its scoped Account settings URL when starting a NyxID service access review, but the shared auth client replaced it with the legacy
/settings?section=accountroute. Approval, denial, and retry therefore returned users to the wrong product surface.Solution
buildWorkflowActivitySettingsHref(scopeId, section)and use it for vNext Settings navigation and review recovery.returnToforserviceAccessReviewand keeps consent mandatory.CONSOLE_HOME_ROUTE.Impact
/scopes/:scopeId/workflow-activity-vnext/settings?section=account/settings?section=accountLocal verification
pnpm exec jest src/pages/auth/callback/index.test.tsx src/pages/workflow-activity-vnext/navigation.test.ts src/pages/workflow-activity-vnext/settings/AccountPanel.test.tsx src/shared/auth/client.test.ts --runInBand- 4 suites, 39 tests passed.pnpm exec jest --findRelatedTests src/pages/auth/callback/index.tsx src/pages/settings/accountContent.tsx src/pages/workflow-activity-vnext/navigation.ts src/pages/workflow-activity-vnext/settings/AccountPanel.tsx src/pages/workflow-activity-vnext/settings/SettingsPage.tsx src/shared/auth/client.ts --runInBand- 57 suites, 1138 tests passed.pnpm exec jest src/pages/auth/callback/index.test.tsx src/pages/settings/index.test.tsx src/pages/workflow-activity-vnext/navigation.test.ts src/pages/workflow-activity-vnext/settings/AccountPanel.test.tsx src/shared/auth/client.test.ts --runInBand- 5 suites, 66 tests passed.pnpm exec jest src/pages/workflow-activity-vnext/index.test.tsx --runInBand -t "renders authoritative identity and the effective workflow execution target"- 1 test passed.pnpm exec biome check <10 analyzer-reported files>- passed with no fixes required.bash tools/ci/test_stability_guards.sh- passed.